Changeset 37346

Timestamp:

05/02/2016 07:12:37 PM (10 years ago)

Author:

westonruter

Message:

Customize: Ensure settings modified during an open save request remain dirty when save request completes.

Also disables Save & Publish button while save request is open. After the save request completes, any settings changed during the request can then be saved via an additional click to the button.

Props chandrapatel, westonruter.
Fixes #32941.

File:

• trunk/src/wp-admin/js/customize-controls.js (modified) (4 diffs)

trunk/src/wp-admin/js/customize-controls.js

@@ -3328 +3328 @@
                                         processing = api.state( 'processing' ),
                                         submitWhenDoneProcessing,
-                                        submit;
+                                        submit,
+                                        modifiedWhileSaving = {};
 
                                 body.addClass( 'saving' );
+
+                                function captureSettingModifiedDuringSave( setting ) {
+                                        modifiedWhileSaving[ setting.id ] = true;
+                                }
+                                api.bind( 'change', captureSettingModifiedDuringSave );
 
                                 submit = function () {
@@ -3339 +3345 @@
                                         request = wp.ajax.post( 'customize_save', query );
 
+                                        // Disable save button during the save request.
+                                        saveBtn.prop( 'disabled', true );
+
                                         api.trigger( 'save', request );
 
                                         request.always( function () {
                                                 body.removeClass( 'saving' );
+                                                saveBtn.prop( 'disabled', false );
+                                                api.unbind( 'change', captureSettingModifiedDuringSave );
                                         } );
 
@@ -3366 +3377 @@
 
                                         request.done( function( response ) {
-                                                // Clear setting dirty states
-                                                api.each( function ( value ) {
-                                                        value._dirty = false;
+
+                                                // Clear setting dirty states, if setting wasn't modified while saving.
+                                                api.each( function( setting ) {
+                                                        if ( ! modifiedWhileSaving[ setting.id ] ) {
+                                                                setting._dirty = false;
+                                                        }
                                                 } );
 
@@ -3374 +3388 @@
 
                                                 api.trigger( 'saved', response );
+
+                                                // Restore the global dirty state if any settings were modified during save.
+                                                if ( ! _.isEmpty( modifiedWhileSaving ) ) {
+                                                        api.state( 'saved' ).set( false );
+                                                }
                                         } );
                                 };