WordPress.org
Get WordPress

Make WordPress Core

Changeset 37361


Ignore:
Timestamp:
05/04/2016 10:06:27 PM (10 years ago)
Author:
helen
Message:

Drop Open Sans in the admin in favor of system fonts.

Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

Location:
trunk/src
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/wp-admin/css/common.css

    r37336 r37361  
    216216        background: #f1f1f1;
    217217        color: #444;
    218         font-family: "Open Sans", sans-serif;
     218        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    219219        font-size: 13px;
    220220        line-height: 1.4em;

  • trunk/src/wp-admin/css/customize-controls.css

    r37230 r37361  
    12201220        clear: both;
    12211221        color: #666;
    1222         font: 24px "Open Sans", sans-serif;
     1222        font: 24px -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    12231223        margin: 30px 0 0 0;
    12241224        padding: 0;

  • trunk/src/wp-admin/css/dashboard.css

    r36904 r37361  
    952952}
    953953
    954 /* Make the browser nags easier to read with Open Sans */
    955 
    956954#dashboard_browser_nag h2.hndle {
    957955        border: none;

  • trunk/src/wp-admin/css/install.css

    r36904 r37361  
    77        background: #fff;
    88        color: #444;
    9         font-family: "Open Sans", sans-serif;
     9        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    1010        margin: 140px auto 25px;
    1111        padding: 20px 20px 10px 20px;
    … …  
    133133textarea {
    134134        border: 1px solid #ddd;
    135         font-family: "Open Sans", sans-serif;
     135        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif
    136136        width: 100%;
    137137        -webkit-box-sizing: border-box;
    … …  
    182182input,
    183183submit {
    184         font-family: "Open Sans", sans-serif;
     184        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    185185}
    186186

  • trunk/src/wp-admin/css/login.css

    r37321 r37361  
    1313        min-width: 0;
    1414        color: #444;
    15         font-family: "Open Sans", sans-serif;
     15        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    1616        font-size: 13px;
    1717        line-height: 1.4em;

  • trunk/src/wp-admin/css/press-this-editor.css

    r33497 r37361  
    7878body {
    7979        color: #404040;
    80         font-family: "Open Sans", Helvetica, Arial, sans-serif;
     80        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    8181        font-size: 20px;
    8282        font-weight: 400;

  • trunk/src/wp-admin/css/press-this.css

    r36904 r37361  
    295295textarea {
    296296        color: #404040;
    297         font-family: "Open Sans", Helvetica, Arial, sans-serif;
     297        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    298298        font-size: 20px;
    299299        font-weight: 400;

  • trunk/src/wp-admin/includes/class-wp-press-this.php

    r37279 r37361  
    794794                }
    795795
    796                 $open_sans_font_url = '';
    797 
    798                 /* translators: If there are characters in your language that are not supported
    799                  * by Open Sans, translate this to 'off'. Do not translate into your own language.
    800                  */
    801                 if ( 'off' !== _x( 'on', 'Open Sans font: on or off' ) ) {
    802                         $subsets = 'latin,latin-ext';
    803 
    804                         /* translators: To add an additional Open Sans character subset specific to your language,
    805                          * translate this to 'greek', 'cyrillic' or 'vietnamese'. Do not translate into your own language.
    806                          */
    807                         $subset = _x( 'no-subset', 'Open Sans font: add new subset (greek, cyrillic, vietnamese)' );
    808 
    809                         if ( 'cyrillic' == $subset ) {
    810                                 $subsets .= ',cyrillic,cyrillic-ext';
    811                         } elseif ( 'greek' == $subset ) {
    812                                 $subsets .= ',greek,greek-ext';
    813                         } elseif ( 'vietnamese' == $subset ) {
    814                                 $subsets .= ',vietnamese';
    815                         }
    816 
    817                         $query_args = array(
    818                                 'family' => urlencode( 'Open Sans:400italic,700italic,400,600,700' ),
    819                                 'subset' => urlencode( $subsets ),
    820                         );
    821 
    822                         $open_sans_font_url = ',' . add_query_arg( $query_args, 'https://fonts.googleapis.com/css' );
    823                 }
    824 
    825                 return $styles . $press_this . $open_sans_font_url;
     796                return $styles . $press_this;
    826797        }
    827798

  • trunk/src/wp-includes/css/admin-bar.css

    r36619 r37361  
    88        text-transform: none;
    99        letter-spacing: normal;
    10         font: normal 13px/32px "Open Sans", sans-serif;
     10        font: normal 13px/32px -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    1111        -webkit-border-radius: 0;
    1212        border-radius: 0;
    … …  
    8080        direction: ltr;
    8181        color: #ccc;
    82         font: normal 13px/32px "Open Sans", sans-serif;
     82        font: normal 13px/32px -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    8383        height: 32px;
    8484        position: fixed;
    … …  
    619619        position: relative;
    620620        z-index: 30;
    621         font: 13px/24px "Open Sans", sans-serif;
     621        font: 13px/24px -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    622622        height: 24px;
    623623        width: 24px;
    … …  
    799799
    800800        #wpadminbar * {
    801                 font: normal 14px/32px "Open Sans", sans-serif;
     801                font: normal 14px/32px -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif, sans-serif;
    802802        }
    803803

  • trunk/src/wp-includes/css/editor.css

    r37174 r37361  
    11101110        color: #666;
    11111111        cursor: pointer;
    1112         font: 13px/19px "Open Sans", sans-serif;
     1112        font-size: 13px;
     1113        line-height: 19px;
    11131114        height: 20px;
    11141115        margin: 5px 0 0 5px;

  • trunk/src/wp-includes/css/media-views.css

    r36904 r37361  
    1818.media-modal,
    1919.media-frame {
    20         font-family: "Open Sans", sans-serif;
     20        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    2121        font-size: 12px;
    2222        -webkit-overflow-scrolling: touch;
    … …  
    8181.media-frame textarea,
    8282.media-frame select {
    83         font-family: "Open Sans", sans-serif;
     83        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    8484        font-size: 12px;
    8585        border-width: 1px;
    … …  
    808808        font-size: 13px;
    809809        color: #444;
    810         font-family: "Open Sans", sans-serif;
     810        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    811811        -webkit-appearance: none;
    812812}

  • trunk/src/wp-includes/css/wp-embed-template.css

    r35466 r37361  
    6060.wp-embed {
    6161        padding: 25px;
    62         font: 400 14px/1.5 'Open Sans', sans-serif;
     62        font: 400 14px/1.5 -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    6363        color: #82878c;
    6464        background: white;
    … …  
    308308        margin: 0 0 10px 0;
    309309        padding: 0 5px;
    310         font: 400 14px/1.5 'Open Sans', sans-serif;
     310        font: 400 14px/1.5 -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    311311        resize: none;
    312312        cursor: text;

  • trunk/src/wp-includes/embed.php

    r36923 r37361  
    878878 */
    879879function enqueue_embed_scripts() {
    880         wp_enqueue_style( 'open-sans' );
    881880        wp_enqueue_style( 'wp-embed-template-ie' );
    882881

  • trunk/src/wp-includes/functions.php

    r37342 r37361  
    26682668                        background: #fff;
    26692669                        color: #444;
    2670                         font-family: "Open Sans", sans-serif;
     2670                        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    26712671                        margin: 2em auto;
    26722672                        padding: 1em 2em;
    … …  
    26792679                        clear: both;
    26802680                        color: #666;
    2681                         font: 24px "Open Sans", sans-serif;
     2681                        font-size: 24px;
    26822682                        margin: 30px 0 0 0;
    26832683                        padding: 0;

  • trunk/src/wp-includes/js/tinymce/plugins/compat3x/css/dialog.css

    r32843 r37361  
    1 @import url("https://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,300,400,600&subset=latin-ext,latin");
    2 
    31/* Generic */
    42body {
    5 font-family: "Open Sans", sans-serif;
     3font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    64font-size:13px;
    75background:#fcfcfc;

  • trunk/src/wp-includes/js/tinymce/skins/wordpress/wp-content.css

    r36976 r37361  
    387387        margin: 0;
    388388        text-align: center;
    389         font-family: 'Open Sans', sans-serif;
     389        font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen-Sans", "Ubuntu", "Cantarell", "Helvetica Neue", sans-serif;
    390390}
    391391

  • trunk/src/wp-includes/script-loader.php

    r37338 r37361  
    698698        $styles->default_dirs = array('/wp-admin/', '/wp-includes/css/');
    699699
     700        // Open Sans is no longer used by core, but may be relied upon by themes and plugins.
    700701        $open_sans_font_url = '';
    701702
    … …  
    744745        $styles->add( 'l10n',                "/wp-admin/css/l10n$suffix.css" );
    745746
    746         $styles->add( 'wp-admin', false, array( 'open-sans', 'dashicons', 'common', 'forms', 'admin-menu', 'dashboard', 'list-tables', 'edit', 'revisions', 'media', 'themes', 'about', 'nav-menus', 'widgets', 'site-icon', 'l10n' ) );
    747 
    748         $styles->add( 'login',               "/wp-admin/css/login$suffix.css", array( 'open-sans', 'dashicons', 'buttons', 'forms', 'l10n' ) );
    749         $styles->add( 'install',             "/wp-admin/css/install$suffix.css", array( 'open-sans', 'buttons' ) );
     747        $styles->add( 'wp-admin', false, array( 'dashicons', 'common', 'forms', 'admin-menu', 'dashboard', 'list-tables', 'edit', 'revisions', 'media', 'themes', 'about', 'nav-menus', 'widgets', 'site-icon', 'l10n' ) );
     748
     749        $styles->add( 'login',               "/wp-admin/css/login$suffix.css", array( 'dashicons', 'buttons', 'forms', 'l10n' ) );
     750        $styles->add( 'install',             "/wp-admin/css/install$suffix.css", array( 'buttons' ) );
    750751        $styles->add( 'wp-color-picker',     "/wp-admin/css/color-picker$suffix.css" );
    751752        $styles->add( 'customize-controls',  "/wp-admin/css/customize-controls$suffix.css", array( 'wp-admin', 'colors', 'ie', 'imgareaselect' ) );
    752753        $styles->add( 'customize-widgets',   "/wp-admin/css/customize-widgets$suffix.css", array( 'wp-admin', 'colors' ) );
    753754        $styles->add( 'customize-nav-menus', "/wp-admin/css/customize-nav-menus$suffix.css", array( 'wp-admin', 'colors' ) );
    754         $styles->add( 'press-this',          "/wp-admin/css/press-this$suffix.css", array( 'open-sans', 'buttons' ) );
     755        $styles->add( 'press-this',          "/wp-admin/css/press-this$suffix.css", array( 'buttons' ) );
    755756
    756757        $styles->add( 'ie', "/wp-admin/css/ie$suffix.css" );
    … …  
    760761        $styles->add( 'buttons',   "/wp-includes/css/buttons$suffix.css" );
    761762        $styles->add( 'dashicons', "/wp-includes/css/dashicons$suffix.css" );
    762         $styles->add( 'open-sans', $open_sans_font_url );
    763763
    764764        // Includes CSS
    765         $styles->add( 'admin-bar',            "/wp-includes/css/admin-bar$suffix.css", array( 'open-sans', 'dashicons' ) );
     765        $styles->add( 'admin-bar',            "/wp-includes/css/admin-bar$suffix.css", array( 'dashicons' ) );
    766766        $styles->add( 'wp-auth-check',        "/wp-includes/css/wp-auth-check$suffix.css", array( 'dashicons' ) );
    767767        $styles->add( 'editor-buttons',       "/wp-includes/css/editor$suffix.css", array( 'dashicons' ) );
    … …  
    784784        $styles->add( 'jcrop',            "/wp-includes/js/jcrop/jquery.Jcrop.min.css", array(), '0.9.12' );
    785785        $styles->add( 'colors-fresh', false, array( 'wp-admin', 'buttons' ) ); // Old handle.
     786        $styles->add( 'open-sans', $open_sans_font_url ); // No longer used in core as of 4.6
    786787
    787788        // RTL CSS
Note: See TracChangeset for help on using the changeset viewer.