WordPress.org

Make WordPress Core


Ignore:
Timestamp:
05/04/2016 10:06:27 PM (3 years ago)
Author:
helen
Message:

Drop Open Sans in the admin in favor of system fonts.

Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-press-this.php

    r37279 r37361  
    794794        }
    795795
    796         $open_sans_font_url = '';
    797 
    798         /* translators: If there are characters in your language that are not supported
    799          * by Open Sans, translate this to 'off'. Do not translate into your own language.
    800          */
    801         if ( 'off' !== _x( 'on', 'Open Sans font: on or off' ) ) {
    802             $subsets = 'latin,latin-ext';
    803 
    804             /* translators: To add an additional Open Sans character subset specific to your language,
    805              * translate this to 'greek', 'cyrillic' or 'vietnamese'. Do not translate into your own language.
    806              */
    807             $subset = _x( 'no-subset', 'Open Sans font: add new subset (greek, cyrillic, vietnamese)' );
    808 
    809             if ( 'cyrillic' == $subset ) {
    810                 $subsets .= ',cyrillic,cyrillic-ext';
    811             } elseif ( 'greek' == $subset ) {
    812                 $subsets .= ',greek,greek-ext';
    813             } elseif ( 'vietnamese' == $subset ) {
    814                 $subsets .= ',vietnamese';
    815             }
    816 
    817             $query_args = array(
    818                 'family' => urlencode( 'Open Sans:400italic,700italic,400,600,700' ),
    819                 'subset' => urlencode( $subsets ),
    820             );
    821 
    822             $open_sans_font_url = ',' . add_query_arg( $query_args, 'https://fonts.googleapis.com/css' );
    823         }
    824 
    825         return $styles . $press_this . $open_sans_font_url;
     796        return $styles . $press_this;
    826797    }
    827798
Note: See TracChangeset for help on using the changeset viewer.