WordPress.org

Make WordPress Core


Ignore:
Timestamp:
05/04/2016 10:06:27 PM (4 years ago)
Author:
helen
Message:

Drop Open Sans in the admin in favor of system fonts.

Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/script-loader.php

    r37338 r37361  
    698698    $styles->default_dirs = array('/wp-admin/', '/wp-includes/css/');
    699699
     700    // Open Sans is no longer used by core, but may be relied upon by themes and plugins.
    700701    $open_sans_font_url = '';
    701702
     
    744745    $styles->add( 'l10n',                "/wp-admin/css/l10n$suffix.css" );
    745746
    746     $styles->add( 'wp-admin', false, array( 'open-sans', 'dashicons', 'common', 'forms', 'admin-menu', 'dashboard', 'list-tables', 'edit', 'revisions', 'media', 'themes', 'about', 'nav-menus', 'widgets', 'site-icon', 'l10n' ) );
    747 
    748     $styles->add( 'login',               "/wp-admin/css/login$suffix.css", array( 'open-sans', 'dashicons', 'buttons', 'forms', 'l10n' ) );
    749     $styles->add( 'install',             "/wp-admin/css/install$suffix.css", array( 'open-sans', 'buttons' ) );
     747    $styles->add( 'wp-admin', false, array( 'dashicons', 'common', 'forms', 'admin-menu', 'dashboard', 'list-tables', 'edit', 'revisions', 'media', 'themes', 'about', 'nav-menus', 'widgets', 'site-icon', 'l10n' ) );
     748
     749    $styles->add( 'login',               "/wp-admin/css/login$suffix.css", array( 'dashicons', 'buttons', 'forms', 'l10n' ) );
     750    $styles->add( 'install',             "/wp-admin/css/install$suffix.css", array( 'buttons' ) );
    750751    $styles->add( 'wp-color-picker',     "/wp-admin/css/color-picker$suffix.css" );
    751752    $styles->add( 'customize-controls',  "/wp-admin/css/customize-controls$suffix.css", array( 'wp-admin', 'colors', 'ie', 'imgareaselect' ) );
    752753    $styles->add( 'customize-widgets',   "/wp-admin/css/customize-widgets$suffix.css", array( 'wp-admin', 'colors' ) );
    753754    $styles->add( 'customize-nav-menus', "/wp-admin/css/customize-nav-menus$suffix.css", array( 'wp-admin', 'colors' ) );
    754     $styles->add( 'press-this',          "/wp-admin/css/press-this$suffix.css", array( 'open-sans', 'buttons' ) );
     755    $styles->add( 'press-this',          "/wp-admin/css/press-this$suffix.css", array( 'buttons' ) );
    755756
    756757    $styles->add( 'ie', "/wp-admin/css/ie$suffix.css" );
     
    760761    $styles->add( 'buttons',   "/wp-includes/css/buttons$suffix.css" );
    761762    $styles->add( 'dashicons', "/wp-includes/css/dashicons$suffix.css" );
    762     $styles->add( 'open-sans', $open_sans_font_url );
    763763
    764764    // Includes CSS
    765     $styles->add( 'admin-bar',            "/wp-includes/css/admin-bar$suffix.css", array( 'open-sans', 'dashicons' ) );
     765    $styles->add( 'admin-bar',            "/wp-includes/css/admin-bar$suffix.css", array( 'dashicons' ) );
    766766    $styles->add( 'wp-auth-check',        "/wp-includes/css/wp-auth-check$suffix.css", array( 'dashicons' ) );
    767767    $styles->add( 'editor-buttons',       "/wp-includes/css/editor$suffix.css", array( 'dashicons' ) );
     
    784784    $styles->add( 'jcrop',            "/wp-includes/js/jcrop/jquery.Jcrop.min.css", array(), '0.9.12' );
    785785    $styles->add( 'colors-fresh', false, array( 'wp-admin', 'buttons' ) ); // Old handle.
     786    $styles->add( 'open-sans', $open_sans_font_url ); // No longer used in core as of 4.6
    786787
    787788    // RTL CSS
Note: See TracChangeset for help on using the changeset viewer.