Changeset 37405

Timestamp:

05/10/2016 06:40:48 AM (9 years ago)

Author:

westonruter

Message:

Customize: Ensure that wp_setup_nav_menu_item filter applies consistently on nav_menu_item setting values.

The filter was being applied in WP_Customize_Nav_Menu_Item_Setting::value() but not in WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item().

Props celloexpressions, westonruter.
Fixes #35203.

Location:

trunk

Files:

• src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php (modified) (1 diff)
• tests/phpunit/tests/customize/nav-menu-item-setting.php (modified) (2 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

@@ -571 +571 @@
         $post->description = apply_filters( 'nav_menu_description', wp_trim_words( $post->description, 200 ) );
 
+        /** This filter is documented in wp-includes/nav-menu.php */
+        $post = apply_filters( 'wp_setup_nav_menu_item', $post );
+
         return $post;
     }

trunk/tests/phpunit/tests/customize/nav-menu-item-setting.php

@@ -767 +767 @@
             'menu_item_parent' => 0,
             'position'         => 2,
-            'type'             => 'post_type',
+            'type'             => 'custom_type',
             'title'            => 'Hello \o/ o\'o World',
             'url'              => '',
@@ -783 +783 @@
 
         $setting->preview();
+
         $nav_menu_item = $setting->value_as_wp_post_nav_menu_item();
+        $this->assertEquals( 'Custom Link', $nav_menu_item->type_label );
+        add_filter( 'wp_setup_nav_menu_item', array( $this, 'filter_type_label' ) );
+        $nav_menu_item = $setting->value_as_wp_post_nav_menu_item();
+        $this->assertEquals( 'Custom Label', $nav_menu_item->type_label );
 
         $this->assertObjectNotHasAttribute( 'nav_menu_term_id', $nav_menu_item );