Changeset 37428 for trunk/tests/phpunit/tests/http/functions.php

Timestamp:

05/13/2016 04:41:45 AM (9 years ago)

Author:

rmccue

Message:

HTTP API: Replace internals with Requests library.

Requests is a library very similar to WP_HTTP, with a high level of unit test coverage, and has a common lineage and development team. It also supports parallel requests.

See #33055.

File:

• trunk/tests/phpunit/tests/http/functions.php (modified) (5 diffs)

trunk/tests/phpunit/tests/http/functions.php

@@ -20 +20 @@
         $headers = wp_remote_retrieve_headers( $response );
 
-        $this->assertInternalType( 'array', $headers, "Reply wasn't array." );
         $this->assertEquals( 'image/jpeg', $headers['content-type'] );
         $this->assertEquals( '40148', $headers['content-length'] );
@@ -37 +36 @@
         $headers = wp_remote_head( $url );
 
-        $this->assertInternalType( 'array', $headers, "Reply wasn't array." );
         $this->assertEquals( '404', wp_remote_retrieve_response_code( $headers ) );
     }
@@ -48 +46 @@
 
         // should return the same headers as a head request
-        $this->assertInternalType( 'array', $headers, "Reply wasn't array." );
         $this->assertEquals( 'image/jpeg', $headers['content-type'] );
         $this->assertEquals( '40148', $headers['content-length'] );
@@ -62 +59 @@
 
         // should return the same headers as a head request
-        $this->assertInternalType( 'array', $headers, "Reply wasn't array." );
         $this->assertEquals( 'image/jpeg', $headers['content-type'] );
         $this->assertEquals( '40148', $headers['content-length'] );
@@ -86 +82 @@
         $cookies  = wp_remote_retrieve_cookies( $response );
 
-        $this->assertInternalType( 'array', $cookies );
         $this->assertNotEmpty( $cookies );