Changeset 37429

Timestamp:

05/13/2016 05:10:52 AM (9 years ago)

Author:

rmccue

Message:

HTTP API: Add browser compatibility hook for 3xx redirects.

WordPress erroneously follows browser-style behaviour with 3xx redirects, where a POST to 302 becomes a GET. Requests instead follows the specification and keeps the same method. Requests also exposes a hook to allow changing the behaviour.

[37428] used the wrong method of adding this hook, now corrected.

See #33055.

Location:

trunk/src/wp-includes

Files:

• class-http.php (modified) (1 diff)
• default-filters.php (modified) (1 diff)

trunk/src/wp-includes/class-http.php

@@ -305 +305 @@
             'useragent' => $r['user-agent'],
             'blocking' => $r['blocking'],
+            'hooks' => new Requests_Hooks(),
         );
+
+        // Ensure redirects follow browser behaviour.
+        $options['hooks']->register( 'requests.before_redirect', array( get_class(), 'browser_redirect_compatibility' ) );
 
         if ( $r['stream'] ) {

trunk/src/wp-includes/default-filters.php

@@ -207 +207 @@
 add_filter( 'title_save_pre',           'trim'                                );
 
-add_filter( 'http_request_host_is_external',    'allowed_http_request_hosts',                          10, 2 );
-add_action( 'requests-requests.before_redirect', array( 'WP_Http', 'browser_redirect_compatibility' ), 10, 5 );
+add_filter( 'http_request_host_is_external',    'allowed_http_request_hosts', 10, 2 );
 
 // REST API filters.