Changeset 37481

Timestamp:

05/22/2016 04:18:22 PM (9 years ago)

Author:

boonebgorges

Message:

In get_page_by_path(), values fetched from cache should obey $output param.

Introduced in [37479].

Props spacedmonkey.
Fixes #36711.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/getPageByPath.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -4246 +4246 @@
             return;
         } else {
-            return get_post( $cached );
+            return get_post( $cached, $output );
         }
     }

trunk/tests/phpunit/tests/post/getPageByPath.php

@@ -243 +243 @@
         $this->assertSame( $num_queries, $wpdb->num_queries );
     }
+
+    /**
+     * @ticket 37611
+     */
+    public function test_output_param_should_be_obeyed_for_cached_value() {
+        $page = self::factory()->post->create( array(
+            'post_type' => 'page',
+            'post_name' => 'foo',
+        ) );
+
+        // Prime cache.
+        $found = get_page_by_path( 'foo' );
+        $this->assertSame( $page, $found->ID );
+
+        $object = get_page_by_path( 'foo', OBJECT );
+        $this->assertInternalType( 'object', $object );
+        $this->assertSame( $page, $object->ID );
+
+        $array_n = get_page_by_path( 'foo', ARRAY_N );
+        $this->assertInternalType( 'array', $array_n );
+        $this->assertSame( $page, $array_n[0] );
+
+        $array_a = get_page_by_path( 'foo', ARRAY_A );
+        $this->assertInternalType( 'array', $array_a );
+        $this->assertSame( $page, $array_a['ID'] );
+    }
 }