Changeset 37565 for trunk/tests/phpunit/tests/bookmark/getBookmarks.php

Timestamp:

05/25/2016 06:29:01 PM (9 years ago)

Author:

boonebgorges

Message:

In get_bookmarks(), don't cache if 'orderby=rand'.

Props lukecavanagh, prettyboymp, c3mdigital, MikeHansenMe.
Fixes #18356.

File:

• trunk/tests/phpunit/tests/bookmark/getBookmarks.php (modified) (1 diff)

trunk/tests/phpunit/tests/bookmark/getBookmarks.php

@@ -48 +48 @@
         $this->assertTrue( $num_queries < $wpdb->num_queries );
     }
+
+    /**
+     * @ticket 18356
+     */
+    public function test_orderby_rand_should_not_be_cached() {
+        global $wpdb;
+
+        $bookmarks = self::factory()->bookmark->create_many( 2 );
+
+        $found1 = get_bookmarks( array(
+            'orderby' => 'rand',
+        ) );
+
+        $num_queries = $wpdb->num_queries;
+
+        $found2 = get_bookmarks( array(
+            'orderby' => 'rand',
+        ) );
+
+        // equal sets != same order
+        $this->assertEqualSets( $found1, $found2 );
+        $this->assertTrue( $num_queries < $wpdb->num_queries );
+    }
 }