Changeset 37567 for trunk/src/wp-includes/taxonomy.php

Timestamp:

05/25/2016 06:44:00 PM (9 years ago)

Author:

boonebgorges

Message:

Fix termmeta pre-fetching in wp_get_object_terms().

[34529] introduced logic intended to prime the termmeta cache for certain
values of the fields parameter. There were a few bugs:

• The all_with_object_id param was misspelled.
• term_id was used instead of ids.
• The values being passed to update_termmeta_cache() in the case where fields=ids was not correct.

All of these would result in a failure to pre-fetch termmeta in some cases.

Props dlh.
Fixes #36932.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -2629 +2629 @@
 
     // Update termmeta cache, if necessary.
-    if ( $args['update_term_meta_cache'] && ( 'all' === $fields || 'all_with_object_ids' === $fields || 'term_id' === $fields ) ) {
-        if ( 'term_id' === $fields ) {
-            $term_ids = $fields;
+    if ( $args['update_term_meta_cache'] && ( 'all' === $fields || 'all_with_object_id' === $fields || 'ids' === $fields ) ) {
+        if ( 'ids' === $fields ) {
+            $term_ids = $terms;
         } else {
             $term_ids = wp_list_pluck( $terms, 'term_id' );