Changeset 37593 for trunk/tests/phpunit/tests/term/wpUpdateTerm.php

Timestamp:

05/30/2016 04:10:16 AM (10 years ago)

Author:

boonebgorges

Message:

Don't clear object relationship caches on term update.

Since [37573], object relationship caches ({$taxonomy}_relationships)
contain term IDs rather than term objects. See #36814. As such, it's no longer
necessary to clear these caches when a term is updated; none of the data that's
changed on update (name, description, count, etc) is stored in the relationship
cache.

Fixes #36251.

File:

• trunk/tests/phpunit/tests/term/wpUpdateTerm.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/wpUpdateTerm.php

@@ -487 +487 @@
                 $this->assertInternalType( 'int', $found['term_id'] );
                 $this->assertInternalType( 'int', $found['term_taxonomy_id'] );
-        }
-
-        public function test_wp_update_term_should_clean_object_term_cache() {
-                register_taxonomy( 'wptests_tax_for_post', 'post' );
-                register_taxonomy( 'wptests_tax_for_page', 'page' );
-                $post = self::factory()->post->create();
-                $page = self::factory()->post->create( array(
-                        'post_type' => 'page',
-                ) );
-
-                $t_for_post = self::factory()->term->create( array(
-                        'taxonomy' => 'wptests_tax_for_post',
-                ) );
-                $t_for_page = self::factory()->term->create( array(
-                        'taxonomy' => 'wptests_tax_for_page',
-                ) );
-
-                wp_set_post_terms( $post, array( $t_for_post ), 'wptests_tax_for_post' );
-                wp_set_post_terms( $page, array( $t_for_page ), 'wptests_tax_for_page' );
-
-                // Prime caches and verify.
-                update_object_term_cache( array( $post ), 'post' );
-                update_object_term_cache( array( $page ), 'page' );
-                $this->assertNotEmpty( wp_cache_get( $post, 'wptests_tax_for_post_relationships' ) );
-                $this->assertNotEmpty( wp_cache_get( $page, 'wptests_tax_for_page_relationships' ) );
-
-                // Update a term in just one of the taxonomies.
-                $found = wp_update_term( $t_for_post, 'wptests_tax_for_post', array(
-                        'slug' => 'foo',
-                ) );
-
-                // Only the relevant cache should have been cleared.
-                $this->assertFalse( wp_cache_get( $post, 'wptests_tax_for_post_relationships' ) );
-                $this->assertNotEmpty( wp_cache_get( $page, 'wptests_tax_for_page_relationships' ) );
         }