Changeset 37594 for trunk/src/wp-includes/class-wp-meta-query.php

Timestamp:

05/30/2016 04:35:16 AM (8 years ago)

Author:

boonebgorges

Message:

In WP_Meta_Query, don't cast meta_value to CHAR.

CHAR is redundant, since the meta_value column is LONGTEXT. Meanwhile,
use of CAST() causes MySQL to ignore any index that the administrator may
have added to the column.

A number of automated tests were doing searches for CAST in the SQL strings
generated by WP_Meta_Query (for reasons unrelated to the CAST() behavior).
These tests have been updated to expect the new query format.

Props ericlewis.
Fixes #36625.

File:

• trunk/src/wp-includes/class-wp-meta-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-meta-query.php

@@ -633 +633 @@
 
             if ( $where ) {
-                $sql_chunks['where'][] = "CAST($alias.meta_value AS {$meta_type}) {$meta_compare} {$where}";
+                if ( 'CHAR' === $meta_type ) {
+                    $sql_chunks['where'][] = "$alias.meta_value {$meta_compare} {$where}";
+                } else {
+                    $sql_chunks['where'][] = "CAST($alias.meta_value AS {$meta_type}) {$meta_compare} {$where}";
+                }
             }
         }