Changeset 37598

Timestamp:

05/31/2016 02:20:58 AM (8 years ago)

Author:

dd32

Message:

Updates: Only use the filename component of URLs to form part of the temporary filename.
Previously we were passing the entire URL to wp_tempnam() (incorrectly) which caused the query string to be used as part of the temporary filename.
We now only use the file component of a url such as https://example.com/filename.zip?arg1=1&arg2=2....&arg100=100 to prevent a long filename.

Fixes #34938

File:

• trunk/src/wp-admin/includes/file.php (modified) (1 diff)

trunk/src/wp-admin/includes/file.php

@@ -494 +494 @@
         return new WP_Error('http_no_url', __('Invalid URL Provided.'));
 
-    $tmpfname = wp_tempnam($url);
+    $url_filename = basename( parse_url( $url, PHP_URL_PATH ) );
+
+    $tmpfname = wp_tempnam( $url_filename );
     if ( ! $tmpfname )
         return new WP_Error('http_no_file', __('Could not create Temporary file.'));