Changeset 37619

Timestamp:

06/02/2016 01:29:25 AM (9 years ago)

Author:

azaozz

Message:

Editor: ensure the page is refreshed when the users navigate to it with the Back or Forward buttons. In these cases the browsers usually load the page from (memory) cache and it contains the old editor content.

Fixes #35852.

Location:

trunk/src/wp-admin/includes

Files:

• admin-filters.php (modified) (1 diff)
• deprecated.php (modified) (1 diff)
• misc.php (modified) (2 diffs)

trunk/src/wp-admin/includes/admin-filters.php

@@ -44 +44 @@
 add_action( 'admin_head', '_ipad_meta'               );
 
-add_action( 'post_edit_form_tag', 'post_form_autocomplete_off' );
+add_action( 'admin_print_scripts-post.php',     'wp_page_reload_on_back_button_js' );
+add_action( 'admin_print_scripts-post-new.php', 'wp_page_reload_on_back_button_js' );
 
 add_action( 'update_option_home',          'update_home_siteurl', 10, 2 );

trunk/src/wp-admin/includes/deprecated.php

@@ -1374 +1374 @@
     return add_menu_page($page_title, $menu_title, $capability, $menu_slug, $function, $icon_url, $_wp_last_utility_menu);
 }
+
+/**
+ * Disables autocomplete on the 'post' form (Add/Edit Post screens) for WebKit browsers,
+ * as they disregard the autocomplete setting on the editor textarea. That can break the editor
+ * when the user navigates to it with the browser's Back button. See #28037
+ *
+ * Replaced with wp_page_reload_on_back_button_js() that also fixes this problem.
+ *
+ * @since 4.0.0
+ * $deprecated 4.6.0
+ *
+ * @global bool $is_safari
+ * @global bool $is_chrome
+ */
+function post_form_autocomplete_off() {
+    global $is_safari, $is_chrome;
+
+    _deprecated_function( __FUNCTION__, '4.6' );
+
+    if ( $is_safari || $is_chrome ) {
+        echo ' autocomplete="off"';
+    }
+}

trunk/src/wp-admin/includes/misc.php

@@ -893 +893 @@
 
 /**
- * Disables autocomplete on the 'post' form (Add/Edit Post screens) for WebKit browsers,
- * as they disregard the autocomplete setting on the editor textarea. That can break the editor
- * when the user navigates to it with the browser's Back button. See #28037
- *
- * @since 4.0.0
- *
- * @global bool $is_safari
- * @global bool $is_chrome
- */
-function post_form_autocomplete_off() {
-    global $is_safari, $is_chrome;
-
-    if ( $is_safari || $is_chrome ) {
-        echo ' autocomplete="off"';
-    }
-}
-
-/**
  * Remove single-use URL parameters and create canonical link based on new URL.
  *
@@ -937 +919 @@
 <?php
 }
+
+/**
+ * Output JS that reloads the page if the user navigated to it with the Back or Forward button.
+ *
+ * Used on the Edit Post and Add New Post screens. Needed to ensure the page is not loaded from browser cache,
+ * so the post title and editor content are the last saved versions. Ideally this script should run first in the head.
+ *
+ * @since 4.6.0
+ */
+function wp_page_reload_on_back_button_js() {
+    ?>
+    <script>
+        if ( typeof performance !== 'undefined' && performance.navigation && performance.navigation.type === 2 ) {
+            document.location.reload( true );
+        }
+    </script>
+    <?php
+}