Changeset 37635

Timestamp:

06/05/2016 12:21:38 PM (7 years ago)

Author:

ocean90

Message:

Upgrader: Don't use Language_Pack_Upgrader_Skin::before() and Language_Pack_Upgrader_Skin::after() when translations are up to date.

Avoids a PHP notice since Language_Pack_Upgrader_Skin::before() tries to access a non-existent update.
Also, change the up_to_date string to use the plural form because translations are only updated in bulk mode.

Fixes #36615.

File:

• trunk/src/wp-admin/includes/class-language-pack-upgrader.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-language-pack-upgrader.php

@@ -115 +115 @@
     public function upgrade_strings() {
         $this->strings['starting_upgrade'] = __( 'Some of your translations need updating. Sit tight for a few more seconds while we update them as well.' );
-        $this->strings['up_to_date'] = __( 'The translation is up to date.' ); // We need to silently skip this case
+        $this->strings['up_to_date'] = __( 'The translations are up to date.' );
         $this->strings['no_package'] = __( 'Update package not available.' );
         $this->strings['downloading_package'] = __( 'Downloading translation from <span class="code">%s</span>&#8230;' );
@@ -182 +182 @@
         if ( empty( $language_updates ) ) {
             $this->skin->header();
-            $this->skin->before();
             $this->skin->set_result( true );
             $this->skin->feedback( 'up_to_date' );
-            $this->skin->after();
             $this->skin->bulk_footer();
             $this->skin->footer();