Changeset 37650

Timestamp:

06/07/2016 03:32:22 AM (9 years ago)

Author:

jorbin

Message:

Build/Test Tools: Run prerelease as the precommit task for configuration file changes

Whenever package.json or Gruntfile.js is updated, we should assume that it affects everything and run the full monty of tasks.

Fixes #36528.
Props iseulde.

File:

• trunk/Gruntfile.js (modified) (1 diff)

trunk/Gruntfile.js

@@ -726 +726 @@
                 }
 
-                [ 'png', 'jpg', 'gif', 'jpeg' ].forEach( function( extension ) {
-                    if ( ( result.stdout + '\n' ).indexOf( '.' + extension + '\n' ) !== -1 ) {
-                        grunt.log.writeln( 'Image files modified. Minifying.');
+                if ( [ 'package.json', 'Gruntfile.js' ].some( function( path ) {
+                    return ( result.stdout + '\n' ).indexOf( ' ' + path + '\n' ) !== -1;
+                } ) ) {
+                    grunt.log.writeln( 'Configuration files modified. Running `prerelease`.' );
+                    taskList.push( 'prerelease' );
+                } else {
+                    if ( [ 'png', 'jpg', 'gif', 'jpeg' ].some( function( extension ) {
+                        return ( result.stdout + '\n' ).indexOf( '.' + extension + '\n' ) !== -1;
+                    } ) ) {
+                        grunt.log.writeln( 'Image files modified. Minifying.' );
                         taskList.push( 'precommit:image' );
                     }
-                } );
-
-                [ 'js', 'css', 'php' ].forEach( function( extension ) {
-                    if ( ( result.stdout + '\n' ).indexOf( '.' + extension + '\n' ) !== -1 ) {
-                        grunt.log.writeln( extension.toUpperCase() + ' files modified. ' + extension.toUpperCase() + ' tests will be run.');
-                        taskList.push( 'precommit:' + extension );
-                    }
-                } );
+
+                    [ 'js', 'css', 'php' ].forEach( function( extension ) {
+                        if ( ( result.stdout + '\n' ).indexOf( '.' + extension + '\n' ) !== -1 ) {
+                            grunt.log.writeln( extension.toUpperCase() + ' files modified. ' + extension.toUpperCase() + ' tests will be run.' );
+                            taskList.push( 'precommit:' + extension );
+                        }
+                    } );
+                }
 
                 grunt.task.run( taskList );