Changeset 37729 for trunk/tests/phpunit/tests/oembed/wpOembed.php

Timestamp:

06/16/2016 05:17:32 PM (9 years ago)

Author:

swissspidy

Message:

Embeds: Enforce a valid post ID when embedding a post from the current site.

Otherwise wp_filter_pre_oembed_result() could erroneously return the HTML of the current post instead of the intended result.

Props kraftbj.
See #36767.

File:

• trunk/tests/phpunit/tests/oembed/wpOembed.php (modified) (2 diffs)

trunk/tests/phpunit/tests/oembed/wpOembed.php

@@ -25 +25 @@
         $this->pre_oembed_result_filtered = $result;
 
-        return $result;
+        // Return false to prevent HTTP requests during tests.
+        return $result ? $result : false;
     }
 
@@ -54 +55 @@
         $this->assertEquals( $this->pre_oembed_result_filtered, $actual );
     }
+
+    public function test_wp_filter_pre_oembed_result_non_existent_post() {
+        $post_id   = self::factory()->post->create();
+        $permalink = get_permalink( $post_id );
+
+        $this->go_to( $permalink );
+        $this->assertQueryTrue( 'is_single', 'is_singular' );
+
+        add_filter( 'pre_oembed_result', array( $this, '_filter_pre_oembed_result' ) );
+        $actual = $this->oembed->get_html( 'https://example.com/' );
+        remove_filter( 'pre_oembed_result', array( $this, '_filter_pre_oembed_result' ) );
+
+        $this->assertTrue( false !== $this->pre_oembed_result_filtered );
+        $this->assertFalse( $actual );
+    }
 }