Changeset 37745

Timestamp:

06/18/2016 09:59:54 AM (9 years ago)

Author:

swissspidy

Message:

Embeds: Improve height calculation for slow loading images.

When the featured image takes longer to load, the browser might not know its exact dimensions yet and therefore sends an incorrect document height to the embedding site.

By sending the document's height again after the featured image has been loaded, we ensure that the iframe doesn't get cut off.

Fixes #35657.

File:

• trunk/src/wp-includes/js/wp-embed-template.js (modified) (1 diff)

trunk/src/wp-includes/js/wp-embed-template.js

@@ -138 +138 @@
          */
         sendEmbedMessage( 'height', Math.ceil( document.body.getBoundingClientRect().height ) );
+
+        // Send the document's height again after the featured image has been loaded.
+        document.querySelector( '.wp-embed-featured-image img' ).addEventListener( 'load', function() {
+            sendEmbedMessage( 'height', Math.ceil( document.body.getBoundingClientRect().height ) );
+        } );
 
         /**