Changeset 37755

Timestamp:

06/21/2016 01:34:19 PM (8 years ago)

Author:

joemcgill

Message:

Media: Restore keyboard navigation of the media grid.

This changes the binding of event listeners in the Attachments Browser
to use on instead of listenTo for the attachment:keydown:arrow and
attachment:details:shift-tab events. The existing listeners broke
when we upgraded Backbone in [36546].

Props adamsilverstein.
Fixes #36900.

Location:

trunk/src/wp-includes/js

Files:

• media-views.js (modified) (1 diff)
• media/views/attachments/browser.js (modified) (1 diff)

trunk/src/wp-includes/js/media-views.js

@@ -4086 +4086 @@
 
         // Add keydown listener to the instance of the Attachments view
-        this.attachments.listenTo( this.controller, 'attachment:keydown:arrow',     this.attachments.arrowEvent );
-        this.attachments.listenTo( this.controller, 'attachment:details:shift-tab', this.attachments.restoreFocus );
+        this.controller.on( 'attachment:keydown:arrow',     _.bind( this.attachments.arrowEvent, this.attachments ) );
+        this.controller.on( 'attachment:details:shift-tab', _.bind( this.attachments.restoreFocus, this.attachments ) );
 
         this.views.add( this.attachments );

trunk/src/wp-includes/js/media/views/attachments/browser.js

@@ -355 +355 @@
 
         // Add keydown listener to the instance of the Attachments view
-        this.attachments.listenTo( this.controller, 'attachment:keydown:arrow',     this.attachments.arrowEvent );
-        this.attachments.listenTo( this.controller, 'attachment:details:shift-tab', this.attachments.restoreFocus );
+        this.controller.on( 'attachment:keydown:arrow',     _.bind( this.attachments.arrowEvent, this.attachments ) );
+        this.controller.on( 'attachment:details:shift-tab', _.bind( this.attachments.restoreFocus, this.attachments ) );
 
         this.views.add( this.attachments );