Changeset 37774

Timestamp:

06/21/2016 02:18:27 PM (10 years ago)

Author:

nbachiyski

Message:

Admin: Escape attachment name in case it contains special characters

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)
• wp-includes/post-template.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -396 +396 @@
                         <?php
                         $file = get_attached_file( $post->ID );
-                        echo wp_basename( $file );
+                        echo esc_html( wp_basename( $file ) );
                         ?>
                 </p>

trunk/src/wp-includes/post-template.php

@@ -1476 +1476 @@
          * @param string|bool  $text      If string, will be link text. Default false.
          */
-        return apply_filters( 'wp_get_attachment_link', "<a href='$url'>$link_text</a>", $id, $size, $permalink, $icon, $text );
+        return apply_filters( 'wp_get_attachment_link', "<a href='" . esc_url( $url ) . "'>$link_text</a>", $id, $size, $permalink, $icon, $text );
 }