Changeset 37789

Timestamp:

06/21/2016 02:24:16 PM (8 years ago)

Author:

nbachiyski

Message:

Admin: Escape attachment name in case it contains special characters

Merge of [37774] to the 4.2 branch.

Location:

branches/4.2/src

Files:

• wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)
• wp-includes/post-template.php (modified) (1 diff)

branches/4.2/src/wp-admin/includes/class-wp-media-list-table.php

@@ -342 +342 @@
             <?php };
             _media_states( $post ); ?></strong>
-            <p class="filename"><?php echo wp_basename( $post->guid ); ?></p>
+            <p class="filename"><?php echo esc_html( wp_basename( $post->guid ) ); ?></p>
 <?php
         echo $this->row_actions( $this->_get_row_actions( $post, $att_title ) );

branches/4.2/src/wp-includes/post-template.php

@@ -1563 +1563 @@
      * @param string|bool $text      If string, will be link text. Default false.
      */
-    return apply_filters( 'wp_get_attachment_link', "<a href='$url'>$link_text</a>", $id, $size, $permalink, $icon, $text );
+    return apply_filters( 'wp_get_attachment_link', "<a href='" . esc_url( $url ) . "'>$link_text</a>", $id, $size, $permalink, $icon, $text );
 }