Changeset 37801

Timestamp:

06/21/2016 02:45:54 PM (8 years ago)

Author:

nbachiyski

Message:

Admin: escape URL-encoded permalinks

File:

• trunk/src/wp-admin/includes/post.php (modified) (3 diffs)

trunk/src/wp-admin/includes/post.php

@@ -1320 +1320 @@
         if ( false !== $view_link ) {
             $display_link = urldecode( $view_link );
-            $return .= '<a id="sample-permalink" href="' . esc_url( $view_link ) . '"' . $preview_target . '>' . $display_link . "</a>\n";
+            $return .= '<a id="sample-permalink" href="' . esc_url( $view_link ) . '"' . $preview_target . '>' . esc_html( $display_link ) . "</a>\n";
         } else {
             $return .= '<span id="sample-permalink">' . $permalink . "</span>\n";
@@ -1344 +1344 @@
         }
 
-        $post_name_html = '<span id="editable-post-name">' . $post_name_abridged . '</span>';
-        $display_link = str_replace( array( '%pagename%', '%postname%' ), $post_name_html, urldecode( $permalink ) );
+        $post_name_html = '<span id="editable-post-name">' . esc_html( $post_name_abridged ) . '</span>';
+        $display_link = str_replace( array( '%pagename%', '%postname%' ), $post_name_html, esc_html( urldecode( $permalink ) ) );
 
         $return = '<strong>' . __( 'Permalink:' ) . "</strong>\n";
@@ -1351 +1351 @@
         $return .= '&lrm;'; // Fix bi-directional text display defect in RTL languages.
         $return .= '<span id="edit-slug-buttons"><button type="button" class="edit-slug button button-small hide-if-no-js" aria-label="' . __( 'Edit permalink' ) . '">' . __( 'Edit' ) . "</button></span>\n";
-        $return .= '<span id="editable-post-name-full">' . $post_name . "</span>\n";
+        $return .= '<span id="editable-post-name-full">' . esc_html( $post_name ) . "</span>\n";
     }