WordPress.org

Make WordPress Core

Changeset 37814


Ignore:
Timestamp:
06/21/2016 02:54:36 PM (4 years ago)
Author:
joemcgill
Message:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 4.3 branch.

See #37111.

Location:
branches/4.3
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/4.3/src/wp-includes/formatting.php

    r34024 r37814  
    12991299 * to manipulate at the command line. Replaces spaces and consecutive
    13001300 * dashes with a single dash. Trims period, dash and underscore from beginning
    1301  * and end of filename.
     1301 * and end of filename. It is not guaranteed that this function will return a
     1302 * filename that is allowed to be uploaded.
    13021303 *
    13031304 * @since 2.1.0
     
    13231324    $filename = preg_replace( '/[\r\n\t -]+/', '-', $filename );
    13241325    $filename = trim( $filename, '.-_' );
     1326
     1327    if ( false === strpos( $filename, '.' ) ) {
     1328        $mime_types = wp_get_mime_types();
     1329        $filetype = wp_check_filetype( 'test.' . $filename, $mime_types );
     1330        if ( $filetype['ext'] === $filename ) {
     1331            $filename = 'unnamed-file.' . $filetype['ext'];
     1332        }
     1333    }
    13251334
    13261335    // Split the filename into a base and extension[s]
  • branches/4.3/tests/phpunit/tests/formatting/SanitizeFileName.php

    r29290 r37814  
    5050        $this->assertEquals("a-t", sanitize_file_name("a    \n\n\nt"));
    5151    }
     52
     53    function test_replaces_unnammed_file_extensions() {
     54        // Test filenames with both supported and unsupported extensions.
     55        $this->assertEquals( 'unnamed-file.exe', sanitize_file_name( '_.exe' ) );
     56        $this->assertEquals( 'unnamed-file.jpg', sanitize_file_name( '_.jpg' ) );
     57    }
     58
     59    function test_replaces_unnammed_file_extensionless() {
     60        // Test a filenames that becomes extensionless.
     61        $this->assertEquals( 'no-extension', sanitize_file_name( '_.no-extension' ) );
     62    }
    5263}
Note: See TracChangeset for help on using the changeset viewer.