WordPress.org

Make WordPress Core

Changeset 37824


Ignore:
Timestamp:
06/21/2016 02:59:46 PM (4 years ago)
Author:
joemcgill
Message:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 3.8 branch.

See #37111.

Location:
branches/3.8
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/3.8/src/wp-includes/formatting.php

    r33524 r37824  
    967967 * to manipulate at the command line. Replaces spaces and consecutive
    968968 * dashes with a single dash. Trims period, dash and underscore from beginning
    969  * and end of filename.
     969 * and end of filename. It is not guaranteed that this function will return a
     970 * filename that is allowed to be uploaded.
    970971 *
    971972 * @since 2.1.0
     
    989990    $filename = preg_replace('/[\s-]+/', '-', $filename);
    990991    $filename = trim($filename, '.-_');
     992
     993    if ( false === strpos( $filename, '.' ) ) {
     994        $mime_types = wp_get_mime_types();
     995        $filetype = wp_check_filetype( 'test.' . $filename, $mime_types );
     996        if ( $filetype['ext'] === $filename ) {
     997            $filename = 'unnamed-file.' . $filetype['ext'];
     998        }
     999    }
    9911000
    9921001    // Split the filename into a base and extension[s]
  • branches/3.8/tests/phpunit/tests/formatting/SanitizeFileName.php

    r25002 r37824  
    3232        $this->assertEquals("a-t", sanitize_file_name("a    \n\n\nt"));
    3333    }
     34
     35    function test_replaces_unnammed_file_extensions() {
     36        // Test filenames with both supported and unsupported extensions.
     37        $this->assertEquals( 'unnamed-file.exe', sanitize_file_name( '_.exe' ) );
     38        $this->assertEquals( 'unnamed-file.jpg', sanitize_file_name( '_.jpg' ) );
     39    }
     40
     41    function test_replaces_unnammed_file_extensionless() {
     42        // Test a filenames that becomes extensionless.
     43        $this->assertEquals( 'no-extension', sanitize_file_name( '_.no-extension' ) );
     44    }
    3445}
Note: See TracChangeset for help on using the changeset viewer.