Changeset 37860 for trunk/src/wp-includes/class-wp-term-query.php

Timestamp:

06/25/2016 04:22:55 PM (10 years ago)

Author:

boonebgorges

Message:

Fix orderby meta handling for WP_Term_Query.

In order to allow meta-related values of orderby to be handled properly,
the term query's meta_query object must run its get_sql() method before
orderby parsing.

Fixing this bug required addressing another bug in WP_Meta_Query, which
caused the table alias index not to be reset when calling get_sql()
multiple times on the same object.

Props littler.chicken.
Fixes #37151.

File:

• trunk/src/wp-includes/class-wp-term-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-term-query.php

@@ -815 +815 @@
         $orderby = '';
 
+        // Tell the meta query to generate its SQL, so we have access to table aliases.
+        $this->meta_query->get_sql( 'term', 't', 'term_id' );
         $meta_clauses = $this->meta_query->get_clauses();
         if ( ! $meta_clauses || ! $orderby_raw ) {