Changeset 37943 for trunk/tests/phpunit/tests/rest-api/rest-server.php

Timestamp:

07/02/2016 11:02:45 PM (9 years ago)

Author:

rachelbaker

Message:

REST API: Reverse order of setting sanitization/validation, validating prior to sanitizing.

Fixes mistake in the current behavior, where the sanitization callback ran before the validation callback. Now the validation callback will run before the sanitization.

Props schlessera, rachelbaker.
See #37247.
Fixes #37192.

File:

• trunk/tests/phpunit/tests/rest-api/rest-server.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-server.php

@@ -942 +942 @@
 
     /**
+     * Make sure that a sanitization that transforms the argument type will not
+     * cause the validation to fail.
+     *
+     * @ticket 37192
+     */
+    public function test_rest_validate_before_sanitization() {
+        register_rest_route( 'test-ns', '/test', array(
+            'methods'  => array( 'GET' ),
+            'callback' => '__return_null',
+            'args' => array(
+                'someinteger' => array(
+                    'validate_callback' => array( $this, '_validate_as_integer_123' ),
+                    'sanitize_callback' => 'absint',
+                ),
+                'somestring'  => array(
+                    'validate_callback' => array( $this, '_validate_as_string_foo' ),
+                    'sanitize_callback' => 'absint',
+                ),
+            ),
+        ) );
+
+        $request = new WP_REST_Request( 'GET', '/test-ns/test' );
+        $request->set_query_params( array( 'someinteger' => 123, 'somestring' => 'foo' ) );
+        $response = $this->server->dispatch( $request );
+
+        $this->assertEquals( 200, $response->get_status() );
+    }
+
+    public function _validate_as_integer_123( $value, $request, $key ) {
+        if ( ! is_int( $value ) ) {
+            return new WP_Error( 'some-error', 'This is not valid!' );
+        }
+
+        return true;
+    }
+
+    public function _validate_as_string_foo( $value, $request, $key ) {
+        if ( ! is_string( $value ) ) {
+            return new WP_Error( 'some-error', 'This is not valid!' );
+        }
+
+        return true;
+    }
+
+    /**
      * @return array {
      *     @type array {