Changeset 37952

Timestamp:

07/04/2016 07:33:43 PM (9 years ago)

Author:

SergeyBiryukov

Message:

Media: Avoid PHP notices when trying to show a parent post title of an orphaned post type.

Props littler.chicken.
See #37186.

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -482 +482 @@
                 <strong><a href="<?php echo get_edit_post_link( $post->post_parent ); ?>">
                     <?php echo $title ?></a></strong><?php
-            } elseif ( current_user_can( 'read_post', $post->post_parent ) ) {
+            } elseif ( $parent_type && current_user_can( 'read_post', $post->post_parent ) ) {
 ?>
                 <strong><?php echo $title ?></strong><?php

trunk/src/wp-includes/media.php

@@ -3063 +3063 @@
     if ( $post_parent ) {
         $parent_type = get_post_type_object( $post_parent->post_type );
+
         if ( $parent_type && $parent_type->show_ui && current_user_can( 'edit_post', $attachment->post_parent ) ) {
             $response['uploadedToLink'] = get_edit_post_link( $attachment->post_parent, 'raw' );
         }
 
-        if ( current_user_can( 'read_post', $attachment->post_parent ) ) {
+        if ( $parent_type && current_user_can( 'read_post', $attachment->post_parent ) ) {
             $response['uploadedToTitle'] = $post_parent->post_title ? $post_parent->post_title : __( '(no title)' );
         }