Changeset 37989 for trunk/tests/phpunit/tests/http/functions.php

Timestamp:

07/06/2016 05:50:44 PM (5 years ago)

Author:

rmccue

Message:

HTTP API: Switch back to returning an array.

The array-compatibility object we started returning in r37428 unfortunately isn't enough like an array. In particular, is_array() checks fail, despite the object implementing ArrayAccess. Mea culpa.

This moves the WP_HTTP_Response object to a new http_response key in the array, and changes the value back to an actual array.

Fixes #37097.
See #33055.

File:

• trunk/tests/phpunit/tests/http/functions.php (modified) (1 diff)

trunk/tests/phpunit/tests/http/functions.php

@@ -23 +23 @@
         $this->assertEquals( '40148', $headers['content-length'] );
         $this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
+    }
+
+    /**
+     * @depends test_head_request
+     */
+    function test_returns_array() {
+        $url = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
+        $response = wp_remote_head( $url );
+        $this->assertInternalType( 'array', $response );
     }