Changeset 38001 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

07/07/2016 02:26:21 PM (9 years ago)

Author:

boonebgorges

Message:

Comments: Cache results of SELECT FOUND_ROWS() query.

When comment IDs are fetched from the cache rather than the database,
the subsequent SELECT FOUND_ROWS() query will not return the correct value.
To avoid unnecessary queries, we cache the results of the found_comments
query alongside the comment IDs.

Props spacedmonkey.
Fixes #37184.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/comment/query.php

@@ -2153 +2153 @@
 
     /**
+     * @ticket 37184
+     */
+    public function test_found_rows_should_be_fetched_from_the_cache() {
+        $comments = self::factory()->comment->create_many( 3, array( 'comment_post_ID' => self::$post_id ) );
+
+        // Prime cache.
+        new WP_Comment_Query( array(
+            'post_id' => self::$post_id,
+            'number' => 2,
+            'no_found_rows' => false,
+        ) );
+
+        $q = new WP_Comment_Query( array(
+            'post_id' => self::$post_id,
+            'number' => 2,
+            'no_found_rows' => false,
+        ) );
+
+        $this->assertEquals( 3, $q->found_comments );
+        $this->assertEquals( 2, $q->max_num_pages );
+    }
+
+    /**
      * @ticket 8071
      */