Changeset 38031

Timestamp:

07/10/2016 07:30:20 PM (9 years ago)

Author:

ocean90

Message:

Accessibility: Add aria-button-if-js class to links in the media list table that behave like buttons when JavaScript is on.

Props joedolson, afercia.
See #26504.
Fixes #36555.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -477 +477 @@
             $title = _draft_or_post_title( $post->post_parent );
             $parent_type = get_post_type_object( $parent->post_type );
-            
+
             if ( $parent_type && $parent_type->show_ui && current_user_can( 'edit_post', $post->post_parent ) ) {
 ?>
@@ -508 +508 @@
                 $title = _draft_or_post_title( $post->post_parent );
                 printf(
-                    '<br /><a href="#the-list" onclick="findPosts.open( \'media[]\', \'%s\' ); return false;" class="hide-if-no-js" aria-label="%s">%s</a>',
+                    '<br /><a href="#the-list" onclick="findPosts.open( \'media[]\', \'%s\' ); return false;" class="hide-if-no-js aria-button-if-js" aria-label="%s">%s</a>',
                     $post->ID,
                     /* translators: %s: attachment title */
@@ -660 +660 @@
                 if ( EMPTY_TRASH_DAYS && MEDIA_TRASH ) {
                     $actions['trash'] = sprintf(
-                        '<a href="%s" class="submitdelete" aria-label="%s">%s</a>',
+                        '<a href="%s" class="submitdelete aria-button-if-js" aria-label="%s">%s</a>',
                         wp_nonce_url( "post.php?action=trash&amp;post=$post->ID", 'trash-post_' . $post->ID ),
                         /* translators: %s: attachment title */
@@ -669 +669 @@
                     $delete_ays = ! MEDIA_TRASH ? " onclick='return showNotice.warn();'" : '';
                     $actions['delete'] = sprintf(
-                        '<a href="%s" class="submitdelete"%s aria-label="%s">%s</a>',
+                        '<a href="%s" class="submitdelete aria-button-if-js"%s aria-label="%s">%s</a>',
                         wp_nonce_url( "post.php?action=delete&amp;post=$post->ID", 'delete-post_' . $post->ID ),
                         $delete_ays,
@@ -688 +688 @@
             if ( current_user_can( 'edit_post', $post->ID ) ) {
                 $actions['attach'] = sprintf(
-                    '<a href="#the-list" onclick="findPosts.open( \'media[]\', \'%s\' ); return false;" class="hide-if-no-js" aria-label="%s">%s</a>',
+                    '<a href="#the-list" onclick="findPosts.open( \'media[]\', \'%s\' ); return false;" class="hide-if-no-js aria-button-if-js" aria-label="%s">%s</a>',
                     $post->ID,
                     /* translators: %s: attachment title */
@@ -709 +709 @@
                 if ( $this->is_trash ) {
                     $actions['untrash'] = sprintf(
-                        '<a href="%s" class="submitdelete" aria-label="%s">%s</a>',
+                        '<a href="%s" class="submitdelete aria-button-if-js" aria-label="%s">%s</a>',
                         wp_nonce_url( "post.php?action=untrash&amp;post=$post->ID", 'untrash-post_' . $post->ID ),
                         /* translators: %s: attachment title */
@@ -717 +717 @@
                 } elseif ( EMPTY_TRASH_DAYS && MEDIA_TRASH ) {
                     $actions['trash'] = sprintf(
-                        '<a href="%s" class="submitdelete" aria-label="%s">%s</a>',
+                        '<a href="%s" class="submitdelete aria-button-if-js" aria-label="%s">%s</a>',
                         wp_nonce_url( "post.php?action=trash&amp;post=$post->ID", 'trash-post_' . $post->ID ),
                         /* translators: %s: attachment title */
@@ -727 +727 @@
                     $delete_ays = ( !$this->is_trash && !MEDIA_TRASH ) ? " onclick='return showNotice.warn();'" : '';
                     $actions['delete'] = sprintf(
-                        '<a href="%s" class="submitdelete"%s aria-label="%s">%s</a>',
+                        '<a href="%s" class="submitdelete aria-button-if-js"%s aria-label="%s">%s</a>',
                         wp_nonce_url( "post.php?action=delete&amp;post=$post->ID", 'delete-post_' . $post->ID ),
                         $delete_ays,