Changeset 38041 for trunk/tests/phpunit/tests/meta/registerMeta.php

Timestamp:

07/13/2016 04:45:50 AM (9 years ago)

Author:

jeremyfelt

Message:

Meta: Ensure filters are backwards compatible for pre-4.6 style meta registration.

When using register_meta() with the function signature from 4.5 and earlier, the auth_{$type}_meta_{$key} and sanitize_{$type}_meta_{$key} filters are used. Any calls to register_meta() expecting this behavior should continue to work. The new filters, which take advantage of object subtypes, should not be added unless the proper $args array is passed.

See #35658.

File:

• trunk/tests/phpunit/tests/meta/registerMeta.php (modified) (1 diff)

trunk/tests/phpunit/tests/meta/registerMeta.php

@@ -33 +33 @@
     }
 
+    public function _old_auth_meta_cb( $allowed, $meta_key, $post_id, $user_id, $cap, $caps ) {
+        return $allowed;
+    }
+
     public function _new_auth_meta_cb( $allowed, $meta_key, $post_id, $user_id, $cap, $caps ) {
         return $allowed;
+    }
+
+    public function test_register_meta_back_compat_with_auth_callback_and_no_sanitize_callback_has_old_style_auth_filter() {
+        register_meta( 'post', 'flight_number', null, array( $this, '_old_auth_meta_cb' ) );
+        $has_filter = has_filter( 'auth_post_meta_flight_number', array( $this, '_old_auth_meta_cb' ) );
+        remove_filter( 'auth_post_meta_flight_number', array( $this, '_old_auth_meta_cb' ) );
+
+        // The filter should have been added with a priority of 10.
+        $this->assertEquals( 10, $has_filter );
+    }
+
+    public function test_register_meta_back_compat_with_sanitize_callback_and_no_auth_callback_has_old_style_sanitize_filter() {
+        register_meta( 'post', 'flight_number', array( $this, '_old_sanitize_meta_cb' ) );
+        $has_filter = has_filter( 'sanitize_post_meta_flight_number', array( $this, '_old_sanitize_meta_cb' ) );
+        remove_filter( 'sanitize_post_meta_flight_number', array( $this, '_old_sanitize_meta_cb' ) );
+
+        $this->assertEquals( 10, $has_filter );
+    }
+
+    public function test_register_meta_back_compat_with_auth_and_sanitize_callback_has_old_style_filters() {
+        register_meta( 'post', 'flight_number', array( $this, '_old_sanitize_meta_cb' ), array( $this, '_old_auth_meta_cb' ) );
+        $has_filters = array();
+        $has_filters['auth'] = has_filter( 'auth_post_meta_flight_number', array( $this, '_old_auth_meta_cb' ) );
+        $has_filters['sanitize'] = has_filter( 'sanitize_post_meta_flight_number', array( $this, '_old_sanitize_meta_cb' ) );
+        remove_filter( 'auth_post_meta_flight_number', array( $this, '_old_auth_meta_cb' ) );
+        remove_filter( 'sanitize_post_meta_flight_number', array( $this, '_old_sanitize_meta_cb' ) );
+
+        $this->assertEquals( array( 'auth' => 10, 'sanitize' => 10 ), $has_filters );
     }