Changeset 38052 for trunk/src/wp-includes/media.php

Timestamp:

07/13/2016 03:23:27 PM (8 years ago)

Author:

joemcgill

Message:

Media: URL encode spaces in srcset attributes.

In some cases, images in the media library may contain spaces in
their filenames. This results in an invalid srcset attribute,
causing broken images on the front end. This change fixes the issue
by replacing spaces in URLs with URL encoded '%20' characters before
returning the srcset string.

Props underdude, joemcgill.
Fixes #36549.

File:

• trunk/src/wp-includes/media.php (modified) (2 diffs)

trunk/src/wp-includes/media.php

@@ -1143 +1143 @@
      * @param string $image_src     The 'src' of the image.
      * @param array  $image_meta    The image meta data as returned by 'wp_get_attachment_metadata()'.
-     * @param int    $attachment_id Image attachment ID or 0.
+     * @param int    $attachment_id Image attachment ID or 0.
      */
     $sources = apply_filters( 'wp_calculate_image_srcset', $sources, $size_array, $image_src, $image_meta, $attachment_id );
@@ -1155 +1155 @@
 
     foreach ( $sources as $source ) {
-        $srcset .= $source['url'] . ' ' . $source['value'] . $source['descriptor'] . ', ';
+        $srcset .= str_replace( ' ', '%20', $source['url'] ) . ' ' . $source['value'] . $source['descriptor'] . ', ';
     }