Changeset 38082 for trunk/src/wp-admin/includes/theme.php

Timestamp:

07/17/2016 09:02:21 PM (8 years ago)

Author:

SergeyBiryukov

Message:

I18N: Remove non-translatable link attributes from translatable strings in wp_plugin_update_row(), wp_theme_update_row(), and get_theme_update_available().

The resulting strings are much easier to translate.

See #36048.

File:

• trunk/src/wp-admin/includes/theme.php (modified) (1 diff)

trunk/src/wp-admin/includes/theme.php

@@ -172 +172 @@
         if ( !is_multisite() ) {
             if ( ! current_user_can('update_themes') ) {
-                /* translators: 1: theme name, 2: theme details URL, 3: accessibility text, 4: version number */
-                $html = sprintf( '<p><strong>' . __( 'There is a new version of %1$s available. <a href="%2$s" class="thickbox open-plugin-details-modal" aria-label="%3$s">View version %4$s details</a>.' ) . '</strong></p>',
+                /* translators: 1: theme name, 2: theme details URL, 3: additional link attributes, 4: version number */
+                $html = sprintf( '<p><strong>' . __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a>.' ) . '</strong></p>',
                     $theme_name,
                     esc_url( $details_url ),
-                    /* translators: 1: theme name, 2: version number */
-                    esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme_name, $update['new_version'] ) ),
+                    sprintf( 'class="thickbox open-plugin-details-modal" aria-label="%s"',
+                        /* translators: 1: theme name, 2: version number */
+                        esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme_name, $update['new_version'] ) )
+                    ),
                     $update['new_version']
                 );
             } elseif ( empty( $update['package'] ) ) {
-                /* translators: 1: theme name, 2: theme details URL, 3: accessibility text, 4: version number */
-                $html = sprintf( '<p><strong>' . __( 'There is a new version of %1$s available. <a href="%2$s" class="thickbox open-plugin-details-modal" aria-label="%3$s">View version %4$s details</a>. <em>Automatic update is unavailable for this theme.</em>' ) . '</strong></p>',
+                /* translators: 1: theme name, 2: theme details URL, 3: additional link attributes, 4: version number */
+                $html = sprintf( '<p><strong>' . __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a>. <em>Automatic update is unavailable for this theme.</em>' ) . '</strong></p>',
                     $theme_name,
                     esc_url( $details_url ),
-                    /* translators: 1: theme name, 2: version number */
-                    esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme_name, $update['new_version'] ) ),
+                    sprintf( 'class="thickbox open-plugin-details-modal" aria-label="%s"',
+                        /* translators: 1: theme name, 2: version number */
+                        esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme_name, $update['new_version'] ) )
+                    ),
                     $update['new_version']
                 );
             } else {
-                /* translators: 1: theme name, 2: theme details URL, 3: accessibility text, 4: version number, 5: update URL, 6: accessibility text */
-                $html = sprintf( '<p><strong>' . __( 'There is a new version of %1$s available. <a href="%2$s" class="thickbox open-plugin-details-modal" aria-label="%3$s">View version %4$s details</a> or <a href="%5$s" aria-label="%6$s" id="update-theme" data-slug="%7$s">update now</a>.' ) . '</strong></p>',
+                /* translators: 1: theme name, 2: theme details URL, 3: additional link attributes, 4: version number, 5: update URL, 6: additional link attributes */
+                $html = sprintf( '<p><strong>' . __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a> or <a href="%5$s" %6$s>update now</a>.' ) . '</strong></p>',
                     $theme_name,
                     esc_url( $details_url ),
-                    /* translators: 1: theme name, 2: version number */
-                    esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme_name, $update['new_version'] ) ),
+                    sprintf( 'class="thickbox open-plugin-details-modal" aria-label="%s"',
+                        /* translators: 1: theme name, 2: version number */
+                        esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme_name, $update['new_version'] ) )
+                    ),
                     $update['new_version'],
                     $update_url,
-                    /* translators: %s: theme name */
-                    esc_attr( sprintf( __( 'Update %s now' ), $theme_name ) ),
-                    $stylesheet
+                    sprintf( 'aria-label="%s" id="update-theme" data-slug="%s"',
+                        /* translators: %s: theme name */
+                        esc_attr( sprintf( __( 'Update %s now' ), $theme_name ) ),
+                        $stylesheet
+                    )
                 );
             }