Changeset 38116

Timestamp:

07/20/2016 02:37:24 PM (8 years ago)

Author:

joemcgill

Message:

Media: Ensure empty alt attributes are set to blank strings.

This is a follow up to [38065] to ensure that wp.html.string() always
converts empty alt attributes to alt="" rather than returning HTML using
empty attribute notation, like alt. This allows screen readers to ignore
images with empty alt attributes, rather than reading out the URL string.

Additionally this completely removes the logic in wp.html.string() for
converting blank attributes to empty attribute notation since empty attribute
notation is generally meant to denote a boolean value, e.g.,
checked == checked="checked", which doesn't apply in this context because
boolean attributes must be omitted in order to represent a false value.
See: ​https://www.w3.org/TR/html5/infrastructure.html#boolean-attributes

Props adamsilverstein, afineman, joemcgill.
Fixes #36735.

File:

• trunk/src/wp-includes/js/shortcode.js (modified) (1 diff)

trunk/src/wp-includes/js/shortcode.js

@@ -327 +327 @@
                 text += ' ' + attr;
 
-                // Use empty attribute notation where possible.
-                if ( '' === value ) {
-                    return;
-                }
-
                 // Convert boolean values to strings.
                 if ( _.isBoolean( value ) ) {