Changeset 38145

Timestamp:

07/23/2016 10:04:20 AM (10 years ago)

Author:

SergeyBiryukov

Message:

Permalinks: In get_page_uri(), don't prepend a parent page slug if it's empty.

Props inderpreet99, SergeyBiryukov.
Fixes #36174.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/getPageUri.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -4334 +4334 @@
         foreach ( $page->ancestors as $parent ) {
                 $parent = get_post( $parent );
-                if ( $parent ) {
+                if ( $parent && $parent->post_name ) {
                         $uri = $parent->post_name . '/' . $uri;
                 }

trunk/tests/phpunit/tests/post/getPageUri.php

@@ -48 +48 @@
 
         /**
+         * @ticket 36174
+         */
+        function test_get_page_uri_with_a_draft_parent_with_empty_slug() {
+                $parent_id = self::factory()->post->create( array( 'post_name' => 'parent' ) );
+                $child_id = self::factory()->post->create( array( 'post_name' => 'child', 'post_parent' => $parent_id ) );
+
+                wp_update_post( array( 'ID' => $parent_id, 'post_name' => '', 'post_status' => 'draft' ) );
+
+                $this->assertEquals( 'child', get_page_uri( $child_id ) );
+        }
+
+        /**
          * @ticket 26284
          */