Changeset 38146

Timestamp:

07/23/2016 10:58:23 AM (8 years ago)

Author:

ocean90

Message:

List Table: Improve WP_Plugins_List_Table::search_box() which was added in [38033].

• Update DocBlock to use third-person singular verb and to include a period at the end.
• Use submit_button() for the submit button.
• Escape the ID attribute.
• Apply the same to WP_List_Table::search_box().

See #37230.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-list-table.php (modified) (2 diffs)
• class-wp-plugins-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -336 +336 @@
 
     /**
-     * Display the search box.
-     *
-     * @since 3.1.0
-     * @access public
-     *
-     * @param string $text The search button text
-     * @param string $input_id The search input id
+     * Displays the search box.
+     *
+     * @since 3.1.0
+     * @access public
+     *
+     * @param string $text     The 'submit' button label.
+     * @param string $input_id ID attribute value for the search input field.
      */
     public function search_box( $text, $input_id ) {
@@ -360 +360 @@
 ?>
 <p class="search-box">
-    <label class="screen-reader-text" for="<?php echo $input_id ?>"><?php echo $text; ?>:</label>
-    <input type="search" id="<?php echo $input_id ?>" name="s" value="<?php _admin_search_query(); ?>" />
-    <?php submit_button( $text, 'button', '', false, array('id' => 'search-submit') ); ?>
+    <label class="screen-reader-text" for="<?php echo esc_attr( $input_id ); ?>"><?php echo $text; ?>:</label>
+    <input type="search" id="<?php echo esc_attr( $input_id ); ?>" name="s" value="<?php _admin_search_query(); ?>" />
+    <?php submit_button( $text, 'button', '', false, array( 'id' => 'search-submit' ) ); ?>
 </p>
 <?php

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -343 +343 @@
 
     /**
-     * Display the search box.
+     * Displays the search box.
      *
      * @since 4.6.0
      * @access public
      *
-     * @param string $text The search button text
-     * @param string $input_id The search input id
+     * @param string $text     The 'submit' button label.
+     * @param string $input_id ID attribute value for the search input field.
      */
     public function search_box( $text, $input_id ) {
@@ -366 +366 @@
         ?>
         <p class="search-box">
-            <label class="screen-reader-text" for="<?php echo $input_id ?>"><?php echo $text; ?>:</label>
-            <input type="search" id="<?php echo $input_id ?>" class="wp-filter-search" name="s" value="<?php _admin_search_query(); ?>" placeholder="<?php esc_attr_e( 'Search installed plugins...' ); ?>"/>
-            <input type="submit" id="search-submit" class="button hide-if-js" value="<?php echo esc_attr( $text ); ?>">
+            <label class="screen-reader-text" for="<?php echo esc_attr( $input_id ); ?>"><?php echo $text; ?>:</label>
+            <input type="search" id="<?php echo esc_attr( $input_id ); ?>" class="wp-filter-search" name="s" value="<?php _admin_search_query(); ?>" placeholder="<?php esc_attr_e( 'Search installed plugins...' ); ?>"/>
+            <?php submit_button( $text, 'button hide-if-js', '', false, array( 'id' => 'search-submit' ) ); ?>
         </p>
         <?php