Changeset 38164 for trunk/tests/phpunit/tests/http/functions.php

Timestamp:

07/27/2016 03:31:48 PM (10 years ago)

Author:

ocean90

Message:

HTTP API: Normalize cookies before passing them to Requests.

Requests has its own cookie object in form of Requests_Cookie. Therefore we have to convert WP_Http_Cookie objects to Requests_Cookie.
This introduces WP_Http_Cookie::get_attributes() to retrieve cookie attributes of a WP_Http_Cookie object and WP_Http::normalize_cookies() to convert the cookie objects.

Fixes #37437.

File:

• trunk/tests/phpunit/tests/http/functions.php (modified) (1 diff)

trunk/tests/phpunit/tests/http/functions.php

@@ -108 +108 @@
         }
 
+        /**
+         * @ticket 37437
+         */
+        function test_get_response_cookies_with_wp_http_cookie_object() {
+                $url = 'http://example.org';
+
+                $response = wp_remote_get( $url, array(
+                        'cookies' => array(
+                                new WP_Http_Cookie( array( 'name' => 'test', 'value' => 'foo' ) ),
+                        ),
+                ) );
+                $cookies  = wp_remote_retrieve_cookies( $response );
+
+                $this->assertNotEmpty( $cookies );
+
+                $cookie = wp_remote_retrieve_cookie( $response, 'test' );
+                $this->assertInstanceOf( 'WP_Http_Cookie', $cookie );
+                $this->assertSame( 'test', $cookie->name );
+                $this->assertSame( 'foo', $cookie->value );
+        }
+
+        /**
+         * @ticket 37437
+         */
+        function test_get_response_cookies_with_name_value_array() {
+                $url = 'http://example.org';
+
+                $response = wp_remote_get( $url, array(
+                        'cookies' => array(
+                                'test' => 'foo',
+                        ),
+                ) );
+                $cookies  = wp_remote_retrieve_cookies( $response );
+
+                $this->assertNotEmpty( $cookies );
+
+                $cookie = wp_remote_retrieve_cookie( $response, 'test' );
+                $this->assertInstanceOf( 'WP_Http_Cookie', $cookie );
+                $this->assertSame( 'test', $cookie->name );
+                $this->assertSame( 'foo', $cookie->value );
+        }
 }