Changeset 38219

Timestamp:

08/08/2016 10:51:40 PM (8 years ago)

Author:

jorbin

Message:

Updates: Standardize JS Custom Event Names

Merges [38218] in to 4.6 branch.

Custom JS events are triggered on the document in order for plugins to have something to hook into. The standard began in #31819 is dash separated and begins with wp to signify the namespace, followed by the subject of our action ( "theme", "plugin", etc.) followed by the action and an optional indicator of status ( "install-success", "deleting" ).

This brings some of the theme hooks in line with the standard. As of now, all plugin actions in src/wp-admin/js/updates.js have an equal corresponding theme action.

Fixes #37598.
See #37512, #37216, #31819.
Props olarmarius, ocean90.

Location:

branches/4.6

Files:

• . (modified) (1 prop)
• src/wp-admin/js/theme.js (modified) (3 diffs)
• src/wp-admin/js/updates.js (modified) (2 diffs)

branches/4.6/src/wp-admin/js/theme.js

@@ -598 +598 @@
         wp.updates.maybeRequestFilesystemCredentials( event );
 
-        $( document ).on( 'wp-install-theme-success', function( event, response ) {
+        $( document ).on( 'wp-theme-install-success', function( event, response ) {
             if ( _this.model.get( 'id' ) === response.slug ) {
                 _this.model.set( { 'installed': true } );
@@ -800 +800 @@
         wp.updates.maybeRequestFilesystemCredentials( event );
 
-        $( document ).one( 'wp-delete-theme-success', function( event, response ) {
+        $( document ).one( 'wp-theme-delete-success', function( event, response ) {
             _this.$el.find( '.close' ).trigger( 'click' );
             $( '[data-slug="' + response.slug + '"' ).css( { backgroundColor:'#faafaa' } ).fadeOut( 350, function() {
@@ -973 +973 @@
         wp.updates.maybeRequestFilesystemCredentials( event );
 
-        $( document ).on( 'wp-install-theme-success', function() {
+        $( document ).on( 'wp-theme-install-success', function() {
             _this.model.set( { 'installed': true } );
         } );

branches/4.6/src/wp-admin/js/updates.js

@@ -1072 +1072 @@
             $message;
 
-        $document.trigger( 'wp-install-theme-success', response );
+        $document.trigger( 'wp-theme-install-success', response );
 
         $message = $card.find( '.button-primary' )
@@ -1244 +1244 @@
         wp.a11y.speak( wp.updates.l10n.deleted, 'polite' );
 
-        $document.trigger( 'wp-delete-theme-success', response );
+        $document.trigger( 'wp-theme-delete-success', response );
     };