Changeset 38220 for branches/4.6/tests/phpunit/tests/canonical/category.php

Timestamp:

08/09/2016 12:12:08 AM (8 years ago)

Author:

boonebgorges

Message:

Improve category check in redirect_canonical() when permastruct contains category slug.

[37262] changed a check in redirect_canonical() so that it checked
categories in the object cache rather than querying the database. However,
the check was based on the identity of WP_Term objects, which in
certain cases can be augmented by the main WP query routine, causing
failures of the in_array() check. This caused unnecessary redirects
for URLs where is_single() is true, but the URL is different from the
post permalink, such as the embed endpoint.

has_term() also checks the cache, but does not sufer from this bug.

Merges [38216] to the 4.6 branch.

Props cmillerdev.
Fixes #36602.

Location:

branches/4.6

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/canonical/category.php (modified) (1 diff)

branches/4.6/tests/phpunit/tests/canonical/category.php

@@ -63 +63 @@
             // Nonexistent category will redirect to correct one.
             array( '/foo/post0/', array( 'url' => '/cat0/post0/', 'qv' => array( 'category_name' => 'cat0', 'name' => 'post0', 'page' => '' ) ) ),
+
+            // Embed URLs should not redirect to post permalinks.
+            array( '/cat0/post0/embed/', array( 'url' => '/cat0/post0/embed/', 'qv' => array( 'category_name' => 'cat0', 'name' => 'post0', 'embed' => 'true' ) ) ),
         );
     }