WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/09/2016 01:15:01 AM (4 years ago)
Author:
jorbin
Message:

Updates: Improve experience for Bulk Actions when FTP is dismissed.

Merges [38221] to the 4.6 branch.

Before this change, when a bulk update was canceled due dismissing the FTP credentials modal, part of the actions didn't get canceled. This meant the "There is a new version of…” notices become blank and the updates you had checked became unchecked. Now, the notices remain and you are essentially returned to the screen you had before. Strings are also updated to improve ARIA usage.

Fixes #37563.
Props ocean90, swissspidy, obenland, afercia.

Location:
branches/4.6
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/4.6

  • branches/4.6/src/wp-admin/includes/class-wp-plugin-install-list-table.php

    r38119 r38222  
    477477                        } elseif ( current_user_can( 'activate_plugins' ) ) {
    478478                            $button_text  = __( 'Activate' );
     479                            /* translators: %s: Plugin name */
     480                            $button_label = _x( 'Activate %s', 'plugin' );
    479481                            $activate_url = add_query_arg( array(
    480482                                '_wpnonce'    => wp_create_nonce( 'activate-plugin_' . $status['file'] ),
     
    485487                            if ( is_network_admin() ) {
    486488                                $button_text  = __( 'Network Activate' );
     489                                /* translators: %s: Plugin name */
     490                                $button_label = _x( 'Network Activate %s', 'plugin' );
    487491                                $activate_url = add_query_arg( array( 'networkwide' => 1 ), $activate_url );
    488492                            }
     
    491495                                '<a href="%1$s" class="button activate-now button-secondary" aria-label="%2$s">%3$s</a>',
    492496                                esc_url( $activate_url ),
    493                                 /* translators: %s: Plugin name */
    494                                 esc_attr( sprintf( _x( 'Activate %s', 'plugin' ), $plugin['name'] ) ),
     497                                esc_attr( sprintf( $button_label, $plugin['name'] ) ),
    495498                                $button_text
    496499                            );
Note: See TracChangeset for help on using the changeset viewer.