Changeset 38263 for trunk/src/wp-includes/post.php

Timestamp:

08/15/2016 07:15:48 PM (8 years ago)

Author:

ocean90

Message:

Post Thumbnails: Restore thumbnail support for media files.

• Allow to add/remove a featured image to attachment:audio and attachment:video post types, see [27657].
• Change conditionals to check for theme OR post type support.
• Add tests for #12922.

Broken in [37658].

Props flixos90, joemcgill, DrewAPicture, wonderboymusic.
See #12922.
Fixes #37658.

File:

• trunk/src/wp-includes/post.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -3260 +3260 @@
     }
 
-    // Set or remove featured image.
-    if ( isset( $postarr['_thumbnail_id'] ) && ( post_type_supports( $post_type, 'thumbnail' ) || 'revision' === $post_type ) ) {
-        $thumbnail_id = intval( $postarr['_thumbnail_id'] );
-        if ( -1 === $thumbnail_id ) {
-            delete_post_thumbnail( $post_ID );
-        } else {
-            set_post_thumbnail( $post_ID, $thumbnail_id );
-        }
-    }
-
     if ( ! empty( $postarr['meta_input'] ) ) {
         foreach ( $postarr['meta_input'] as $field => $value ) {
@@ -3290 +3280 @@
         if ( ! empty( $postarr['context'] ) ) {
             add_post_meta( $post_ID, '_wp_attachment_context', $postarr['context'], true );
+        }
+    }
+
+    // Set or remove featured image.
+    if ( isset( $postarr['_thumbnail_id'] ) ) {
+        $thumbnail_support = current_theme_supports( 'post-thumbnails', $post_type ) && post_type_supports( $post_type, 'thumbnail' ) || 'revision' === $post_type;
+        if ( ! $thumbnail_support && 'attachment' === $post_type && $post_mime_type ) {
+            if ( wp_attachment_is( 'audio', $post_ID ) ) {
+                $thumbnail_support = post_type_supports( 'attachment:audio', 'thumbnail' ) || current_theme_supports( 'post-thumbnails', 'attachment:audio' );
+            } elseif ( wp_attachment_is( 'video', $post_ID ) ) {
+                $thumbnail_support = post_type_supports( 'attachment:video', 'thumbnail' ) || current_theme_supports( 'post-thumbnails', 'attachment:video' );
+            }
+        }
+
+        if ( $thumbnail_support ) {
+            $thumbnail_id = intval( $postarr['_thumbnail_id'] );
+            if ( -1 === $thumbnail_id ) {
+                delete_post_thumbnail( $post_ID );
+            } else {
+                set_post_thumbnail( $post_ID, $thumbnail_id );
+            }
         }
     }