Changeset 38296 for trunk/src/wp-includes/media.php

Timestamp:

08/21/2016 06:14:37 AM (9 years ago)

Author:

wonderboymusic

Message:

Media: use wp_get_attachment_metadata() instead of get_post_meta() where appropriate.

Adds unit test.

Props JorritSchippers.
Fixes #36246.

File:

• trunk/src/wp-includes/media.php (modified) (5 diffs)

trunk/src/wp-includes/media.php

@@ -862 +862 @@
         // Generate 'srcset' and 'sizes' if not already present.
         if ( empty( $attr['srcset'] ) ) {
-            $image_meta = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );
+            $image_meta = wp_get_attachment_metadata( $attachment_id );
 
             if ( is_array( $image_meta ) ) {
@@ -991 +991 @@
 
     if ( ! is_array( $image_meta ) ) {
-        $image_meta = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );
+        $image_meta = wp_get_attachment_metadata( $attachment_id );
     }
 
@@ -1207 +1207 @@
 
     if ( ! is_array( $image_meta ) ) {
-        $image_meta = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );
+        $image_meta = wp_get_attachment_metadata( $attachment_id );
     }
 
@@ -1240 +1240 @@
     } elseif ( is_string( $size ) ) {
         if ( ! $image_meta && $attachment_id ) {
-            $image_meta = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );
+            $image_meta = wp_get_attachment_metadata( $attachment_id );
         }
 
@@ -1315 +1315 @@
 
     foreach ( $selected_images as $image => $attachment_id ) {
-        $image_meta = get_post_meta( $attachment_id, '_wp_attachment_metadata', true );
+        $image_meta = wp_get_attachment_metadata( $attachment_id );
         $content = str_replace( $image, wp_image_add_srcset_and_sizes( $image, $image_meta, $attachment_id ), $content );
     }