Changeset 38307 for trunk/src/wp-includes/option.php

Timestamp:

08/22/2016 06:24:48 PM (10 years ago)

Author:

DrewAPicture

Message:

Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation.

Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.

Props ramiy.
See #37748.

File:

• trunk/src/wp-includes/option.php (modified) (26 diffs)

trunk/src/wp-includes/option.php

@@ -50 +50 @@
          * @param string     $option     Option name.
          */
-        $pre = apply_filters( 'pre_option_' . $option, false, $option );
+        $pre = apply_filters( "pre_option_{$option}", false, $option );
         if ( false !== $pre )
                 return $pre;
@@ -73 +73 @@
                          * @param string $option  Option name.
                          */
-                        return apply_filters( 'default_option_' . $option, $default, $option );
+                        return apply_filters( "default_option_{$option}", $default, $option );
                 }
 
@@ -134 +134 @@
          * @param string $option Option name.
          */
-        return apply_filters( 'option_' . $option, maybe_unserialize( $value ), $option );
+        return apply_filters( "option_{$option}", maybe_unserialize( $value ), $option );
 }
 
@@ -278 +278 @@
          * @param string $option    Option name.
          */
-        $value = apply_filters( 'pre_update_option_' . $option, $value, $old_value, $option );
+        $value = apply_filters( "pre_update_option_{$option}", $value, $old_value, $option );
 
         /**
@@ -535 +535 @@
                  * @param string $option Name of the deleted option.
                  */
-                do_action( "delete_option_$option", $option );
+                do_action( "delete_option_{$option}", $option );
 
                 /**
@@ -569 +569 @@
          * @param string $transient Transient name.
          */
-        do_action( 'delete_transient_' . $transient, $transient );
+        do_action( "delete_transient_{$transient}", $transient );
 
         if ( wp_using_ext_object_cache() ) {
@@ -625 +625 @@
          * @param string $transient     Transient name.
          */
-        $pre = apply_filters( 'pre_transient_' . $transient, false, $transient );
+        $pre = apply_filters( "pre_transient_{$transient}", false, $transient );
         if ( false !== $pre )
                 return $pre;
@@ -662 +662 @@
          * @param string $transient Transient name.
          */
-        return apply_filters( 'transient_' . $transient, $value, $transient );
+        return apply_filters( "transient_{$transient}", $value, $transient );
 }
 
@@ -697 +697 @@
          * @param string $transient  Transient name.
          */
-        $value = apply_filters( 'pre_set_transient_' . $transient, $value, $expiration, $transient );
+        $value = apply_filters( "pre_set_transient_{$transient}", $value, $expiration, $transient );
 
         /**
@@ -710 +710 @@
          * @param string $transient  Transient name.
          */
-        $expiration = apply_filters( 'expiration_of_transient_' . $transient, $expiration, $value, $transient );
+        $expiration = apply_filters( "expiration_of_transient_{$transient}", $expiration, $value, $transient );
 
         if ( wp_using_ext_object_cache() ) {
@@ -759 +759 @@
                  * @param string $transient  The name of the transient.
                  */
-                do_action( 'set_transient_' . $transient, $value, $expiration, $transient );
+                do_action( "set_transient_{$transient}", $value, $expiration, $transient );
 
                 /**
@@ -1107 +1107 @@
          * @param string $option     Option name.
          */
-        $pre = apply_filters( 'pre_site_option_' . $option, false, $option );
+        $pre = apply_filters( "pre_site_option_{$option}", false, $option );
 
         if ( false !== $pre ) {
@@ -1131 +1131 @@
                  * @param string $option  Option name.
                  */
-                return apply_filters( 'default_site_option_' . $option, $default, $option );
+                return apply_filters( "default_site_option_{$option}", $default, $option );
         }
 
@@ -1175 +1175 @@
          * @param string $option Option name.
          */
-        return apply_filters( 'site_option_' . $option, $value, $option );
+        return apply_filters( "site_option_{$option}", $value, $option );
 }
 
@@ -1223 +1223 @@
          * @param string $option Option name.
          */
-        $value = apply_filters( 'pre_add_site_option_' . $option, $value, $option );
+        $value = apply_filters( "pre_add_site_option_{$option}", $value, $option );
 
         $notoptions_key = "$network_id:notoptions";
@@ -1272 +1272 @@
                  * @param mixed  $value  Value of the network option.
                  */
-                do_action( 'add_site_option_' . $option, $option, $value );
+                do_action( "add_site_option_{$option}", $option, $value );
 
                 /**
@@ -1328 +1328 @@
          * @param string $option Option name.
          */
-        do_action( 'pre_delete_site_option_' . $option, $option );
+        do_action( "pre_delete_site_option_{$option}", $option );
 
         if ( ! is_multisite() ) {
@@ -1355 +1355 @@
                  * @param string $option Name of the network option.
                  */
-                do_action( 'delete_site_option_' . $option, $option );
+                do_action( "delete_site_option_{$option}", $option );
 
                 /**
@@ -1418 +1418 @@
          * @param string $option    Option name.
          */
-        $value = apply_filters( 'pre_update_site_option_' . $option, $value, $old_value, $option );
+        $value = apply_filters( "pre_update_site_option_{$option}", $value, $old_value, $option );
 
         if ( $value === $old_value ) {
@@ -1463 +1463 @@
                  * @param mixed  $old_value Old value of the network option.
                  */
-                do_action( 'update_site_option_' . $option, $option, $value, $old_value );
+                do_action( "update_site_option_{$option}", $option, $value, $old_value );
 
                 /**
@@ -1501 +1501 @@
          * @param string $transient Transient name.
          */
-        do_action( 'delete_site_transient_' . $transient, $transient );
+        do_action( "delete_site_transient_{$transient}", $transient );
 
         if ( wp_using_ext_object_cache() ) {
@@ -1558 +1558 @@
          * @param string $transient          Transient name.
          */
-        $pre = apply_filters( 'pre_site_transient_' . $transient, false, $transient );
+        $pre = apply_filters( "pre_site_transient_{$transient}", false, $transient );
 
         if ( false !== $pre )
@@ -1594 +1594 @@
          * @param string $transient Transient name.
          */
-        return apply_filters( 'site_transient_' . $transient, $value, $transient );
+        return apply_filters( "site_transient_{$transient}", $value, $transient );
 }
 
@@ -1626 +1626 @@
          * @param string $transient Transient name.
          */
-        $value = apply_filters( 'pre_set_site_transient_' . $transient, $value, $transient );
+        $value = apply_filters( "pre_set_site_transient_{$transient}", $value, $transient );
 
         $expiration = (int) $expiration;
@@ -1641 +1641 @@
          * @param string $transient  Transient name.
          */
-        $expiration = apply_filters( 'expiration_of_site_transient_' . $transient, $expiration, $value, $transient );
+        $expiration = apply_filters( "expiration_of_site_transient_{$transient}", $expiration, $value, $transient );
 
         if ( wp_using_ext_object_cache() ) {
@@ -1672 +1672 @@
                  * @param string $transient  Transient name.
                  */
-                do_action( 'set_site_transient_' . $transient, $value, $expiration, $transient );
+                do_action( "set_site_transient_{$transient}", $value, $expiration, $transient );
 
                 /**