Changeset 38330

Timestamp:

08/23/2016 01:42:36 PM (8 years ago)

Author:

boonebgorges

Message:

Tests: Attachment create() method should match signature of other create() methods.

Legacy argument format continues to be accepted.

Props bcole808.
See #37630.

File:

• trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-attachment.php (modified) (1 diff)

trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-attachment.php

@@ -3 +3 @@
 class WP_UnitTest_Factory_For_Attachment extends WP_UnitTest_Factory_For_Post {
 
-    function create_object( $file, $parent = 0, $args = array() ) {
-        return wp_insert_attachment( $args, $file, $parent );
+    /**
+     * Create an attachment fixture.
+     *
+     * @param array $args {
+     *     Array of arguments. Accepts all arguments that can be passed to
+     *     wp_insert_attachment(), in addition to the following:
+     *     @type int    $post_parent ID of the post to which the attachment belongs.
+     *     @type string $file        Path of the attached file.
+     * }
+     * @param int   $legacy_parent Deprecated.
+     * @param array $legacy_args   Deprecated
+     */
+    function create_object( $args, $legacy_parent = 0, $legacy_args = array() ) {
+        // Backward compatibility for legacy argument format.
+        if ( is_string( $args ) ) {
+            $file = $args;
+            $args = $legacy_args;
+            $args['post_parent'] = $legacy_parent;
+            $args['file'] = $file;
+        }
+
+        $r = array_merge( array(
+            'file' => '',
+            'parent' => 0,
+        ), $args );
+
+        return wp_insert_attachment( $r, $r['file'], $r['post_parent'] );
     }