Changeset 38337

Timestamp:

08/23/2016 02:44:19 PM (10 years ago)

Author:

wonderboymusic

Message:

Taxonomy: in get_terms(), do not assume that legacy args are being passed when the only params are top-level meta_* values. Add keys in WP_Term_Query::__construct().

Adds unit tests.

Props flixos90, boonebgorges.
Fixes #37568.

Location:

trunk

Files:

• src/wp-includes/class-wp-term-query.php (modified) (1 diff)
• tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-term-query.php

@@ -209 +209 @@
                         'update_term_meta_cache' => true,
                         'meta_query'             => '',
+                        'meta_key'               => '',
+                        'meta_value'             => '',
+                        'meta_type'              => '',
+                        'meta_compare'           => '',
                 );
 

trunk/tests/phpunit/tests/term/getTerms.php

@@ -10 +10 @@
                 _clean_term_filters();
                 wp_cache_delete( 'last_changed', 'terms' );
+        }
+
+        /**
+         * @ticket 37568
+         */
+        public function test_meta_query_args_only() {
+                register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
+
+                $term1 = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+                $term2 = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+
+                $post = self::factory()->post->create( array( 'post_type' => 'post' ) );
+
+                update_term_meta( $term1, 'somekey', 'thevalue' );
+
+                wp_set_post_terms( $post, array( $term1, $term2 ), 'wptests_tax' );
+
+                $found = get_terms( array(
+                        'meta_key' => 'somekey',
+                        'meta_value' => 'thevalue',
+                ) );
+
+                $this->assertEqualSets( array( $term1 ), wp_list_pluck( $found, 'term_id' ) );
         }