Changeset 38355 for trunk/src/wp-admin/includes/class-wp-site-icon.php

Timestamp:

08/25/2016 07:08:38 PM (3 years ago)

Author:

wonderboymusic

Message:

Site Icon: There is no good reason for class-wp-site-icon.php to drop a global instance of itself whenever the file is loaded. The lone use of the global instance of WP_Site_Icon is in an AJAX action that provides virtually no way to override - the file is loaded immediately before the global is used.

Let us remove the $wp_site_icon global. I will fall on the sword if this comes back to bite us (waiting with bated breath).

See #37699.

File:

• trunk/src/wp-admin/includes/class-wp-site-icon.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-icon.php

@@ -241 +241 @@
     }
 }
-
-/**
- * @global WP_Site_Icon $wp_site_icon
- */
-$GLOBALS['wp_site_icon'] = new WP_Site_Icon;