Changeset 38381 for trunk/src/wp-includes/class-wp-comment.php

Timestamp:

08/26/2016 07:08:23 PM (8 years ago)

Author:

boonebgorges

Message:

Don't improperly cast IDs when fetching post, user, or term objects.

Blindly casting passed IDs to integers can generate false positives
when the ID is cast to 1.

Props deeptiboddapati.
Fixes #37738.

File:

• trunk/src/wp-includes/class-wp-comment.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment.php

@@ -192 +192 @@
         global $wpdb;
 
+        if ( ! is_numeric( $id ) || $id != floor( $id ) || ! $id ) {
+            return false;
+        }
+
         $comment_id = (int) $id;
-        if ( ! $comment_id ) {
-            return false;
-        }
 
         $_comment = wp_cache_get( $comment_id, 'comment' );