Changeset 38382 for trunk/tests/phpunit/tests/cron.php

Timestamp:

08/26/2016 08:21:30 PM (7 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Remove many unnecessary calls to rand_str() which can, in theory, fail at random. Static strings are much more appropriate.

See #37371

File:

• trunk/tests/phpunit/tests/cron.php (modified) (4 diffs)

trunk/tests/phpunit/tests/cron.php

@@ -40 +40 @@
     function test_schedule_event_single_args() {
         // schedule an event with arguments and make sure it's returned by wp_next_scheduled
-        $hook = rand_str();
-        $timestamp = strtotime('+1 hour');
-        $args = array(rand_str());
+        $hook = 'event';
+        $timestamp = strtotime('+1 hour');
+        $args = array('foo');
 
         wp_schedule_single_event( $timestamp, $hook, $args );
@@ -49 +49 @@
         // these don't match so return nothing
         $this->assertEquals( false, wp_next_scheduled($hook) );
-        $this->assertEquals( false, wp_next_scheduled($hook, array(rand_str())) );
+        $this->assertEquals( false, wp_next_scheduled($hook, array('bar')) );
 
         // it's a non recurring event
@@ -70 +70 @@
     function test_schedule_event_args() {
         // schedule an event and make sure it's returned by wp_next_scheduled
-        $hook = rand_str();
+        $hook = 'event';
         $timestamp = strtotime('+1 hour');
         $recur = 'hourly';
-        $args = array(rand_str());
+        $args = array('foo');
 
         wp_schedule_event( $timestamp, 'hourly', $hook, $args );
@@ -80 +80 @@
         // these don't match so return nothing
         $this->assertEquals( false, wp_next_scheduled($hook) );
-        $this->assertEquals( false, wp_next_scheduled($hook, array(rand_str())) );
+        $this->assertEquals( false, wp_next_scheduled($hook, array('bar')) );
 
         $this->assertEquals( $recur, wp_get_schedule($hook, $args) );