Changeset 38382 for trunk/tests/phpunit/tests/query/results.php

Timestamp:

08/26/2016 08:21:30 PM (9 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Remove many unnecessary calls to rand_str() which can, in theory, fail at random. Static strings are much more appropriate.

See #37371

File:

• trunk/tests/phpunit/tests/query/results.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/results.php

@@ -457 +457 @@
      */
     function test_query_author_vars() {
-        $author_1 = self::factory()->user->create( array( 'user_login' => 'admin1', 'user_pass' => rand_str(), 'role' => 'author' ) );
-        $post_1 = self::factory()->post->create( array( 'post_title' => rand_str(), 'post_author' => $author_1, 'post_date' => '2007-01-01 00:00:00' ) );
-
-        $author_2 = self::factory()->user->create( array( 'user_login' => rand_str(), 'user_pass' => rand_str(), 'role' => 'author' ) );
-        $post_2 = self::factory()->post->create( array( 'post_title' => rand_str(), 'post_author' => $author_2, 'post_date' => '2007-01-01 00:00:00' ) );
-
-        $author_3 = self::factory()->user->create( array( 'user_login' => rand_str(), 'user_pass' => rand_str(), 'role' => 'author' ) );
-        $post_3 = self::factory()->post->create( array( 'post_title' => rand_str(), 'post_author' => $author_3, 'post_date' => '2007-01-01 00:00:00' ) );
-
-        $author_4 = self::factory()->user->create( array( 'user_login' => rand_str(), 'user_pass' => rand_str(), 'role' => 'author' ) );
-        $post_4 = self::factory()->post->create( array( 'post_title' => rand_str(), 'post_author' => $author_4, 'post_date' => '2007-01-01 00:00:00' ) );
+        $author_1 = self::factory()->user->create( array( 'user_login' => 'author1', 'role' => 'author' ) );
+        $post_1 = self::factory()->post->create( array( 'post_title' => 'Post 1', 'post_author' => $author_1, 'post_date' => '2007-01-01 00:00:00' ) );
+
+        $author_2 = self::factory()->user->create( array( 'user_login' => 'author2', 'role' => 'author' ) );
+        $post_2 = self::factory()->post->create( array( 'post_title' => 'Post 2', 'post_author' => $author_2, 'post_date' => '2007-01-01 00:00:00' ) );
+
+        $author_3 = self::factory()->user->create( array( 'user_login' => 'author3', 'role' => 'author' ) );
+        $post_3 = self::factory()->post->create( array( 'post_title' => 'Post 3', 'post_author' => $author_3, 'post_date' => '2007-01-01 00:00:00' ) );
+
+        $author_4 = self::factory()->user->create( array( 'user_login' => 'author4', 'role' => 'author' ) );
+        $post_4 = self::factory()->post->create( array( 'post_title' => 'Post 4', 'post_author' => $author_4, 'post_date' => '2007-01-01 00:00:00' ) );
 
         $posts = $this->q->query( array(
@@ -550 +550 @@
 
         $posts = $this->q->query( array(
-            'author_name' => 'admin1',
+            'author_name' => 'author1',
             'post__in' => array( $post_1, $post_2, $post_3, $post_4 )
         ) );