Changeset 38465

Timestamp:

08/31/2016 06:24:57 AM (8 years ago)

Author:

wonderboymusic

Message:

Press This: in wp_ajax_press_this_save_post() and wp_ajax_press_this_add_category(), don't check for a global instance. WP_Press_This is a Controller, but not really a Singleton. This also keeps it from being a pluggable class, which it is right now.

See #37699.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -3114 +3114 @@
  *
  * @since 4.2.0
- *
- * @global WP_Press_This $wp_press_this
  */
 function wp_ajax_press_this_save_post() {
-    if ( empty( $GLOBALS['wp_press_this'] ) ) {
-        $GLOBALS['wp_press_this'] = new WP_Press_This();
-    }
-
-    $GLOBALS['wp_press_this']->save_post();
+    $wp_press_this = new WP_Press_This();
+    $wp_press_this->save_post();
 }
 
@@ -3129 +3124 @@
  *
  * @since 4.2.0
- *
- * @global WP_Press_This $wp_press_this
  */
 function wp_ajax_press_this_add_category() {
-    if ( empty( $GLOBALS['wp_press_this'] ) ) {
-        $GLOBALS['wp_press_this'] = new WP_Press_This();
-    }
-
-    $GLOBALS['wp_press_this']->add_category();
+    $wp_press_this = new WP_Press_This();
+    $wp_press_this->add_category();
 }